From: Andrew Lunn <andrew@lunn.ch>
To: Rob Herring <robh@kernel.org>
Cc: Robert Marko <robert.marko@sartura.hr>,
agross@kernel.org, bjorn.andersson@linaro.org,
linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org,
devicetree@vger.kernel.org, davem@davemloft.net, kuba@kernel.org,
netdev@vger.kernel.org, linux@armlinux.org.uk,
Luka Perkov <luka.perkov@sartura.hr>
Subject: Re: [PATCH 2/4] dt-bindings: net: Add bindings for Qualcomm QCA807x
Date: Sun, 3 Jan 2021 17:59:55 +0100 [thread overview]
Message-ID: <X/H4C1eBNHdDS4vO@lunn.ch> (raw)
In-Reply-To: <20210103164613.GA4012977@robh.at.kernel.org>
> > > + qcom,tx-driver-strength:
> > > + description: PSGMII/QSGMII TX driver strength control.
> > > + $ref: /schemas/types.yaml#/definitions/uint32
> > > + enum: [0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12]
> >
> > Please use the actual values here, and have the driver convert to the
> > value poked into the register. So the property would be
> > qcom,tx-driver-strength-mv and it would have the value 220 for
> > example.
>
> The LED binding has properties for specifying the current already. And
> it's max current which is the h/w property where as anything less is
> just software configuration (IOW, doesn't belong in DT).
Hi Rob
My understanding of this is it is the drive strength of the SERDES
line. Nothing to do with LEDs. The description needs improving.
Andrew
next prev parent reply other threads:[~2021-01-03 17:00 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-22 22:26 [PATCH 0/4] Add support for Qualcomm QCA807x PHYs Robert Marko
2020-12-22 22:26 ` [PATCH 1/4] dt-bindings: net: Add QCA807x PHY Robert Marko
2020-12-22 22:26 ` [PATCH 2/4] dt-bindings: net: Add bindings for Qualcomm QCA807x Robert Marko
2020-12-23 0:56 ` Andrew Lunn
2021-01-03 16:46 ` Rob Herring
2021-01-03 16:59 ` Andrew Lunn [this message]
2021-01-07 16:41 ` Robert Marko
2021-01-07 16:39 ` Robert Marko
2020-12-22 22:26 ` [PATCH 3/4] net: phy: Add Qualcomm QCA807x driver Robert Marko
2020-12-23 1:23 ` Andrew Lunn
2020-12-23 17:07 ` Jakub Kicinski
2020-12-22 22:26 ` [PATCH 4/4] MAINTAINERS: Add entry for Qualcomm QCA807x PHY driver Robert Marko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=X/H4C1eBNHdDS4vO@lunn.ch \
--to=andrew@lunn.ch \
--cc=agross@kernel.org \
--cc=bjorn.andersson@linaro.org \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=kuba@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=luka.perkov@sartura.hr \
--cc=netdev@vger.kernel.org \
--cc=robert.marko@sartura.hr \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox