From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4C88EC433E0 for ; Wed, 6 Jan 2021 17:52:15 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id EA56F2311B for ; Wed, 6 Jan 2021 17:52:14 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727372AbhAFRv7 (ORCPT ); Wed, 6 Jan 2021 12:51:59 -0500 Received: from mail.kernel.org ([198.145.29.99]:55804 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727176AbhAFRv6 (ORCPT ); Wed, 6 Jan 2021 12:51:58 -0500 Received: by mail.kernel.org (Postfix) with ESMTPSA id B044A2311B; Wed, 6 Jan 2021 17:51:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1609955478; bh=AQpKhsAGsqhFg0SXDC3NmRpXTX27a/Y5tEj0l9Oqrfs=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=MOm/PHzou5OnLA39Woslo2/GbRyZixIxWIQdAos9BNeA/tw3KQPLkSOfjG/wJBwnI qpeFqDBfJsJiMe2T7cVadDGjtiJuBLVHYKNJnhoi3EMCbwk2Yl64N5e8O4ttXC2O6q s4qH0oqg2lGPYwVfxNioX6jSFr6Aml4M1hzB6PLs= Date: Wed, 6 Jan 2021 18:52:39 +0100 From: Greg Kroah-Hartman To: Filip Kolev Cc: devel@driverdev.osuosl.org, Mauro Carvalho Chehab , linux-kernel@vger.kernel.org, Sakari Ailus , linux-media@vger.kernel.org Subject: Re: [PATCH] media: atomisp: ov2722: replace hardcoded function name Message-ID: References: <20210105202945.26913-1-fil.kolev@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jan 06, 2021 at 07:43:42PM +0200, Filip Kolev wrote: > > > On 06-Jan-21 09:51, Greg Kroah-Hartman wrote: > > On Tue, Jan 05, 2021 at 10:29:18PM +0200, Filip Kolev wrote: > > > There is a debug message using hardcoded function name instead of the > > > __func__ macro. Replace it. > > > > > > Report from checkpatch.pl on the file: > > > > > > WARNING: Prefer using '"%s...", __func__' to using 'ov2722_remove', this function's name, in a string > > > + dev_dbg(&client->dev, "ov2722_remove...\n"); > > > > > > Signed-off-by: Filip Kolev > > > --- > > > drivers/staging/media/atomisp/i2c/atomisp-ov2722.c | 2 +- > > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > > > diff --git a/drivers/staging/media/atomisp/i2c/atomisp-ov2722.c b/drivers/staging/media/atomisp/i2c/atomisp-ov2722.c > > > index eecefcd734d0e..21d6bc62d452a 100644 > > > --- a/drivers/staging/media/atomisp/i2c/atomisp-ov2722.c > > > +++ b/drivers/staging/media/atomisp/i2c/atomisp-ov2722.c > > > @@ -1175,7 +1175,7 @@ static int ov2722_remove(struct i2c_client *client) > > > struct v4l2_subdev *sd = i2c_get_clientdata(client); > > > struct ov2722_device *dev = to_ov2722_sensor(sd); > > > - dev_dbg(&client->dev, "ov2722_remove...\n"); > > > + dev_dbg(&client->dev, "%s...\n", __func__); > > > > dev_dbg() provides the function name already, and this is just a "trace" > > call, and ftrace should be used instead, so the whole line should be > > removed entirely. > > Thank you for the review! > > How do I go about this? Do I amend the patch and re-send as v2 or create a > new patch entirely? New patch entirely please. thanks, greg k-h