public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: zhenwei pi <pizhenwei@bytedance.com>,
	arnd@arndb.de, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 2/2] misc: pvpanic: introduce module parameter 'events'
Date: Fri, 8 Jan 2021 16:15:16 +0100	[thread overview]
Message-ID: <X/h3BAdea48p+L+p@kroah.com> (raw)
In-Reply-To: <58eca97c-f72e-66a7-2696-611124ce0943@redhat.com>

On Fri, Jan 08, 2021 at 04:04:24PM +0100, Paolo Bonzini wrote:
> On 08/01/21 15:07, Greg KH wrote:
> > >   static void __iomem *base;
> > > +static unsigned int events = PVPANIC_PANICKED | PVPANIC_CRASH_LOADED;
> > > +module_param(events, uint, 0644);
> > > +MODULE_PARM_DESC(events, "set event limitation of pvpanic device");
> > I do not understand you wanting a module parameter as well as a sysfs
> > file.  Why is this needed?  Why are you spreading this information out
> > across different apis and locations?
> 
> It can be useful to disable some functionality, for example in case you want
> to fake running on an older virtualization host.  This can be done for
> debugging reasons, or to keep uniform handling across a fleet that is
> running different versions of QEMU.

And where is this all going to be documented?

And what's wrong with just making the sysfs attribute writable?

thanks,

greg k-h

  reply	other threads:[~2021-01-08 15:14 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-01-08 13:52 [PATCH v3 0/2] misc: pvpanic: introduce capability & module parameter zhenwei pi
2021-01-08 13:52 ` [PATCH v3 1/2] misc: pvpanic: introduce device capability zhenwei pi
2021-01-08 14:06   ` Greg KH
2021-01-08 13:52 ` [PATCH v3 2/2] misc: pvpanic: introduce module parameter 'events' zhenwei pi
2021-01-08 14:07   ` Greg KH
2021-01-08 15:04     ` Paolo Bonzini
2021-01-08 15:15       ` Greg KH [this message]
2021-01-08 15:26         ` Paolo Bonzini
2021-01-09 11:31           ` Greg KH
2021-01-10  3:10             ` [External] " zhenwei pi
2021-01-11 18:27             ` Paolo Bonzini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=X/h3BAdea48p+L+p@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=arnd@arndb.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=pbonzini@redhat.com \
    --cc=pizhenwei@bytedance.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox