Re: [PATCH v5 09/15] lib/test_printf.c: Use helper function to unwind array of software_nodes

Laurent Pinchart
2021-01-10T11:17:46Z

Hi Andy,

On Sat, Jan 09, 2021 at 11:07:33AM +0200, Andy Shevchenko wrote:
> On Saturday, January 9, 2021, Laurent Pinchart wrote:
>
> > Hi Peter, Steven and Sergey,
> >
> > Could you please let us know if you're fine with this patch getting
> > merged in v5.12 through the linux-media tree ? The cover letter contains
> > additional details (in a nutshell, this is a cross-tree series and we
> > would like to avoid topic branches if possible).
>
> There is already a tag by Petr.

I saw that, but looking at the corresponding e-mail, there was no clear
acknowledgement that we could merge this patch through a different tree.

> > On Thu, Jan 07, 2021 at 01:28:32PM +0000, Daniel Scally wrote:
> > > Use the software_node_unregister_nodes() helper function to unwind this
> > > array in a cleaner way.
> > >
> > > Acked-by: Petr Mladek <pmladek@suse.com>
> > > Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> > > Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> > > Reviewed-by: Sergey Senozhatsky <sergey.senozhatsky@gmail.com>
> > > Suggested-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> > > Signed-off-by: Daniel Scally <djrscally@gmail.com>
> > > ---
> > > Changes in v5:
> > >
> > > - None
> > >
> > > lib/test_printf.c | 4 +---
> > > 1 file changed, 1 insertion(+), 3 deletions(-)
> > >
> > > diff --git a/lib/test_printf.c b/lib/test_printf.c
> > > index 7ac87f18a10f..7d60f24240a4 100644
> > > --- a/lib/test_printf.c
> > > +++ b/lib/test_printf.c
> > > @@ -644,9 +644,7 @@ static void __init fwnode_pointer(void)
> > > test(second_name, "%pfwP", software_node_fwnode(&softnodes[1]));
> > > test(third_name, "%pfwP", software_node_fwnode(&softnodes[2]));
> > >
> > > - software_node_unregister(&softnodes[2]);
> > > - software_node_unregister(&softnodes[1]);
> > > - software_node_unregister(&softnodes[0]);
> > > + software_node_unregister_nodes(softnodes);
> > > }
> > >
> > > static void __init

--
Regards,

Laurent Pinchart