From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F0BF7C433DB for ; Mon, 11 Jan 2021 14:17:58 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id C2C592242A for ; Mon, 11 Jan 2021 14:17:58 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732196AbhAKOR6 (ORCPT ); Mon, 11 Jan 2021 09:17:58 -0500 Received: from vps0.lunn.ch ([185.16.172.187]:33288 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727304AbhAKOR4 (ORCPT ); Mon, 11 Jan 2021 09:17:56 -0500 Received: from andrew by vps0.lunn.ch with local (Exim 4.94) (envelope-from ) id 1kyy0H-00HXVo-Ez; Mon, 11 Jan 2021 15:17:05 +0100 Date: Mon, 11 Jan 2021 15:17:05 +0100 From: Andrew Lunn To: Marco Felsch Cc: hkallweit1@gmail.com, linux@armlinux.org.uk, davem@davemloft.net, kuba@kernel.org, f.fainelli@gmail.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, kernel@pengutronix.de Subject: Re: [PATCH] net: phy: smsc: fix clk error handling Message-ID: References: <20210111085932.28680-1-m.felsch@pengutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210111085932.28680-1-m.felsch@pengutronix.de> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jan 11, 2021 at 09:59:32AM +0100, Marco Felsch wrote: > Commit bedd8d78aba3 ("net: phy: smsc: LAN8710/20: add phy refclk in > support") added the phy clk support. The commit already checks if > clk_get_optional() throw an error but instead of returning the error it > ignores it. > > Fixes: bedd8d78aba3 ("net: phy: smsc: LAN8710/20: add phy refclk in support") > Suggested-by: Jakub Kicinski > Signed-off-by: Marco Felsch Reviewed-by: Andrew Lunn Andrew