public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: Gao Yan <gao.yanB@h3c.com>
Cc: jirislaby@kernel.org, paulus@samba.org, davem@davemloft.net,
	kuba@kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] [v2]net:ppp: remove disc_data_lock in ppp line discipline
Date: Fri, 1 Jan 2021 09:18:48 +0100	[thread overview]
Message-ID: <X+7a6OudZwupatGw@kroah.com> (raw)
In-Reply-To: <20210101033718.45198-1-gao.yanB@h3c.com>

On Fri, Jan 01, 2021 at 11:37:18AM +0800, Gao Yan wrote:
> In tty layer, it provides tty->ldisc_sem to protect all tty_ldisc_ops
> including ppp_sync_ldisc. So I think tty->ldisc_sem can also
> protect tty->disc_data, and the disc_data_lock is not necessary.
> 
> Signed-off-by: Gao Yan <gao.yanB@h3c.com>
> ---
>  drivers/net/ppp/ppp_async.c   | 11 ++---------
>  drivers/net/ppp/ppp_synctty.c | 12 ++----------
>  2 files changed, 4 insertions(+), 19 deletions(-)

What changed from v1?

And how did you test this?  Why remove this lock, is it causing problems
somewhere for it to be here?

thanks,

greg k-h

  reply	other threads:[~2021-01-01  8:20 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-01-01  3:37 [PATCH] [v2]net:ppp: remove disc_data_lock in ppp line discipline Gao Yan
2021-01-01  8:18 ` Greg KH [this message]
2021-01-04 18:29 ` Jakub Kicinski
  -- strict thread matches above, loose matches on Subject: below --
2021-01-01  9:03 Gaoyan
2021-01-05  7:14 Gaoyan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=X+7a6OudZwupatGw@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=davem@davemloft.net \
    --cc=gao.yanB@h3c.com \
    --cc=jirislaby@kernel.org \
    --cc=kuba@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=paulus@samba.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox