linux-next: Signed-off-by missing for commit in the fpga tree

linux-next: Signed-off-by missing for commit in the fpga tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 638 bytes --]

Hi all,

Commits

  aaf8fe39c952 ("Revert "fpga: dfl: fix the definitions of type & feature_id for dfl devices"")
  9922e71f43ac ("Revert "fpga: dfl: move dfl_device_id to mod_devicetable.h"")
  3ae706b58b0b ("Revert "fpga: dfl: add dfl bus support to MODULE_DEVICE_TABLE()"")
  dd57ca7ddec5 ("Revert "fpga: dfl: move dfl bus related APIs to include/linux/dfl.h"")

are missing a Signed-off-by from their author and committer.

Reverts are commits, too.  It is also very useful for the commit message
of a revert to contain some reason(s) for the revert as this may help
future developers.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: Signed-off-by missing for commit in the fpga tree

[Moritz Fischer]

On Mon, Nov 16, 2020 at 09:52:40AM +1100, Stephen Rothwell wrote:
> Hi all,
> 
> Commits
> 
>   aaf8fe39c952 ("Revert "fpga: dfl: fix the definitions of type & feature_id for dfl devices"")
>   9922e71f43ac ("Revert "fpga: dfl: move dfl_device_id to mod_devicetable.h"")
>   3ae706b58b0b ("Revert "fpga: dfl: add dfl bus support to MODULE_DEVICE_TABLE()"")
>   dd57ca7ddec5 ("Revert "fpga: dfl: move dfl bus related APIs to include/linux/dfl.h"")
> 
> are missing a Signed-off-by from their author and committer.
> 
> Reverts are commits, too.  It is also very useful for the commit message
> of a revert to contain some reason(s) for the revert as this may help
> future developers.
> 
> -- 
> Cheers,
> Stephen Rothwell

Sorry, thanks for catching that, for posterity the reason was
that Greg had some further comments and didn't take the pull-request
as-is, so I wanted to have the next-tree reflect that.

I'll be more careful next time,

- Moritz

linux-next: Signed-off-by missing for commit in the fpga tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 409 bytes --]

Hi all,

Commits

  7269868818a4 ("fpga: fpga-region: fix kernel-doc formatting issues")
  d73ef1ed7300 ("fpga: Use tab instead of space indentation")
  154970f89f06 ("fpga: fpga-mgr: fix kernel-doc warnings")
  d0749c3c95fc ("fpga: fix for coding style issues")

are missing a Signed-off-by from their committer.

(A danger of rebasing omeone else's commits ..)

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: Signed-off-by missing for commit in the fpga tree

[Moritz Fischer]

Ugh..

On Mon, May 9, 2022 at 9:56 PM Stephen Rothwell <sfr@canb.auug.org.au> wrote:
>
> Hi all,
>
> Commits
>
>   7269868818a4 ("fpga: fpga-region: fix kernel-doc formatting issues")
>   d73ef1ed7300 ("fpga: Use tab instead of space indentation")
>   154970f89f06 ("fpga: fpga-mgr: fix kernel-doc warnings")
>   d0749c3c95fc ("fpga: fix for coding style issues")
>
> are missing a Signed-off-by from their committer.
>
> (A danger of rebasing omeone else's commits ..)
>
> --
> Cheers,
> Stephen Rothwell

Ok, there are some other issues on the current next branch. We'll clean that up.

Thanks for flagging this,
Moritz

linux-next: Signed-off-by missing for commit in the fpga tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 170 bytes --]

Hi all,

Commit

  7617b957c6dd ("fpga: Explicitly include correct DT includes")

is missing a Signed-off-by from its committer.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]