public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: Alexandru Ardelean <alexandru.ardelean@analog.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] uio/uio_pci_generic: remove unneeded pci_set_drvdata()
Date: Fri, 20 Nov 2020 16:46:07 +0100	[thread overview]
Message-ID: <X7fkv1m4CvCcCbzF@kroah.com> (raw)
In-Reply-To: <20201119145906.73727-1-alexandru.ardelean@analog.com>

On Thu, Nov 19, 2020 at 04:59:06PM +0200, Alexandru Ardelean wrote:
> The pci_get_drvdata() was moved during commit ef84928cff58
> ("uio/uio_pci_generic: use device-managed function equivalents").
> 
> I should have notice that the pci_set_drvdata() requires a
> pci_get_drvdata() for it to make sense.
> 
> Signed-off-by: Alexandru Ardelean <alexandru.ardelean@analog.com>
> ---
> 
> Apologies for not noticing this sooner.
> If this can be squashed into commit ef84928cff58 , then it's also fine.
> I've started seeing that there actually more xxx_set_drvdata() leftovers
> in the entire kernel, and I pinged the checkpatch crew to add a check
> for this.
> 
> https://lore.kernel.org/lkml/CA+U=Dspy5+RE9agcLr6eY9DCMa1c5+++0JLeugMMBRXz4YLj1w@mail.gmail.com/T/#u

I can't squash existing public commits.  Can you resend this and add a
"Fixes:" tag to it to show what commit it fixes so we can track this
properly?

thanks,

greg k-h

  reply	other threads:[~2020-11-20 15:45 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-11-19 14:59 [PATCH] uio/uio_pci_generic: remove unneeded pci_set_drvdata() Alexandru Ardelean
2020-11-20 15:46 ` Greg KH [this message]
2020-11-21  7:56   ` Ardelean, Alexandru
2020-11-23 14:34 ` [PATCH v2] " Alexandru Ardelean
2020-11-24  6:59   ` Ardelean, Alexandru

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=X7fkv1m4CvCcCbzF@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=alexandru.ardelean@analog.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox