From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5861AC4361B for ; Tue, 8 Dec 2020 03:50:15 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 24A3A239EB for ; Tue, 8 Dec 2020 03:50:15 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726241AbgLHDuO (ORCPT ); Mon, 7 Dec 2020 22:50:14 -0500 Received: from mail.kernel.org ([198.145.29.99]:60306 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725853AbgLHDuN (ORCPT ); Mon, 7 Dec 2020 22:50:13 -0500 Date: Mon, 7 Dec 2020 19:49:15 -0800 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1607399373; bh=K+AuuBZl4hBPvkhnz+5DsdlBPwu1F5l2MO6LkZGaZhg=; h=From:To:Cc:Subject:References:In-Reply-To:From; b=m43jbMlV5Adfj+4GDftjqlqK9gsflMPNoZNr0MNhv8r7E2laJOnOhRlrbHijhOOYa JgTL1IJS4RlKO85/Dm6SoqZq8DakS5MNbROKyuu3D+VcoQM97Q3QB/nXM7onSTSelY TZKG9cYrbJIKaqsJ0hU4hp1/bC9LabTo0EnTv+4DFm/JAVYS1CMJerRQW2cb4q1uka cNwakO6vJoc4vFMyQYRqWZslvNfHROcig2VARRAQhn9vuie077K7YdbdP4/0W2ZGpr 6DM9Pt+4KSrM0xVhyO+qePsDeF78nMBdex5a+qkWEv9yvWolb7hZ8gfqot9aB9Jspy EKgQA9IUPI3+Q== From: Eric Biggers To: Daeho Jeong Cc: linux-kernel@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net, kernel-team@android.com, Daeho Jeong Subject: Re: [f2fs-dev] [PATCH v3] f2fs: add F2FS_IOC_DECOMPRESS_FILE and F2FS_IOC_COMPRESS_FILE Message-ID: References: <20201203065615.402494-1-daeho43@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20201203065615.402494-1-daeho43@gmail.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Dec 03, 2020 at 03:56:15PM +0900, Daeho Jeong wrote: > From: Daeho Jeong > > Added two ioctl to decompress/compress explicitly the compression > enabled file in "compress_mode=user" mount option. > > Using these two ioctls, the users can make a control of compression > and decompression of their files. > > Signed-off-by: Daeho Jeong > --- I still don't understand the purpose of these new ioctls. What's wrong with just FS_IOC_SETFLAGS(FS_COMPRESS_FL) to compress a file, or FS_IOC_SETFLAGS(0) to decompress a file? That appears to already be supported... - Eric