From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2FD17C433FE for ; Tue, 8 Dec 2020 01:27:02 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id E1EA323A40 for ; Tue, 8 Dec 2020 01:27:01 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726299AbgLHB0q (ORCPT ); Mon, 7 Dec 2020 20:26:46 -0500 Received: from mail.kernel.org ([198.145.29.99]:44482 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725995AbgLHB0p (ORCPT ); Mon, 7 Dec 2020 20:26:45 -0500 Date: Mon, 7 Dec 2020 17:26:03 -0800 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1607390765; bh=dKxMYGEJk/qsfEljvMrUx1suvymwSnTOX+Nd8kkjqAU=; h=From:To:Cc:Subject:References:In-Reply-To:From; b=lU3x0KdOCyqLG0bPUqEzQKEK6FINx4Paat/QU4vCgl2l6XPe/G3mIHZEWKXCsLA4S Xqshe2PrpSSIwniVht2EnpD6EZClKo8wjvWa2UItV/0bZUs8JzOAK2wOCkXI203DgZ HOXs8HjeblvoAOT8eovsvqpwgxVtKkcWB5OQRaIyhreM2UmzHagvFmCRjKjTNSQRhG QCcNuRlIBUMz2rv95yJL5nXsain7p73KwTPYy5dgTfmdLSHQDexWIanSZiY81TQNRU JpRT12rSlNmCUuvGaLWWuzkA64nlbB+ol4hIE1pTuwmyLmYx5pWGAImV4Ji21Td/GT dUQg/XZ2sK8IQ== From: Jaegeuk Kim To: Chao Yu Cc: Eric Biggers , linux-kernel@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net Subject: Re: [f2fs-dev] [PATCH v3] f2fs: compress: support chksum Message-ID: References: <20201126103209.67985-1-yuchao0@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 12/08, Chao Yu wrote: > On 2020/12/8 4:37, Eric Biggers wrote: > > On Thu, Nov 26, 2020 at 06:32:09PM +0800, Chao Yu wrote: > > > + if (!ret && fi->i_compress_flag & 1 << COMPRESS_CHKSUM) { > > > > This really could use some parentheses. People shouldn't have to look up a > > C operator precedence table to understand the code. > > Will add parentheses to avoid misread. > > > > > > + u32 provided = le32_to_cpu(dic->cbuf->chksum); > > > + u32 calculated = f2fs_crc32(sbi, dic->cbuf->cdata, dic->clen); > > > + > > > + if (provided != calculated) { > > > + if (!is_inode_flag_set(dic->inode, FI_COMPRESS_CORRUPT)) { > > > + set_inode_flag(dic->inode, FI_COMPRESS_CORRUPT); > > > + printk_ratelimited( > > > + "%sF2FS-fs (%s): checksum invalid, nid = %lu, %x vs %x", > > > + KERN_INFO, sbi->sb->s_id, dic->inode->i_ino, > > > + provided, calculated); > > > + } > > > + set_sbi_flag(sbi, SBI_NEED_FSCK); > > > + WARN_ON_ONCE(1); > > > > WARN, WARN_ON_ONCE, BUG, BUG_ON, etc. are only for kernel bugs, not for invalid > > inputs from disk or userspace. > > > > There is already a log message printed just above, so it seems this WARN_ON_ONCE > > should just be removed. > > Jaegeuk wants to give WARN_ON and marking a FSCK flag without returning EFSCORRUPTED, I think above printk_ratelimited should be enough. > > Jaegeuk, thoughts? > > Thanks, > > > > > - Eric > > . > >