* [PATCH] misc: altera-stapl: remove trailing semicolon in macro definition
@ 2020-11-27 16:54 trix
2020-11-27 17:03 ` Greg KH
0 siblings, 1 reply; 3+ messages in thread
From: trix @ 2020-11-27 16:54 UTC (permalink / raw)
To: arnd, gregkh; +Cc: linux-kernel, Tom Rix
From: Tom Rix <trix@redhat.com>
The macro use will already have a semicolon.
Signed-off-by: Tom Rix <trix@redhat.com>
---
drivers/misc/altera-stapl/altera-jtag.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/misc/altera-stapl/altera-jtag.c b/drivers/misc/altera-stapl/altera-jtag.c
index 27e8e0c9e8cf..0238600107b0 100644
--- a/drivers/misc/altera-stapl/altera-jtag.c
+++ b/drivers/misc/altera-stapl/altera-jtag.c
@@ -17,9 +17,9 @@
#include "altera-jtag.h"
#define alt_jtag_io(a, b, c)\
- astate->config->jtag_io(astate->config->dev, a, b, c);
+ astate->config->jtag_io(astate->config->dev, a, b, c)
-#define alt_malloc(a) kzalloc(a, GFP_KERNEL);
+#define alt_malloc(a) kzalloc(a, GFP_KERNEL)
/*
* This structure shows, for each JTAG state, which state is reached after
--
2.18.4
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] misc: altera-stapl: remove trailing semicolon in macro definition
2020-11-27 16:54 [PATCH] misc: altera-stapl: remove trailing semicolon in macro definition trix
@ 2020-11-27 17:03 ` Greg KH
2020-11-27 17:42 ` Tom Rix
0 siblings, 1 reply; 3+ messages in thread
From: Greg KH @ 2020-11-27 17:03 UTC (permalink / raw)
To: trix; +Cc: arnd, linux-kernel
On Fri, Nov 27, 2020 at 08:54:21AM -0800, trix@redhat.com wrote:
> From: Tom Rix <trix@redhat.com>
>
> The macro use will already have a semicolon.
>
> Signed-off-by: Tom Rix <trix@redhat.com>
> ---
> drivers/misc/altera-stapl/altera-jtag.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/misc/altera-stapl/altera-jtag.c b/drivers/misc/altera-stapl/altera-jtag.c
> index 27e8e0c9e8cf..0238600107b0 100644
> --- a/drivers/misc/altera-stapl/altera-jtag.c
> +++ b/drivers/misc/altera-stapl/altera-jtag.c
> @@ -17,9 +17,9 @@
> #include "altera-jtag.h"
>
> #define alt_jtag_io(a, b, c)\
> - astate->config->jtag_io(astate->config->dev, a, b, c);
> + astate->config->jtag_io(astate->config->dev, a, b, c)
>
> -#define alt_malloc(a) kzalloc(a, GFP_KERNEL);
> +#define alt_malloc(a) kzalloc(a, GFP_KERNEL)
Ick, really? That macro should be removed entirely. Can you redo this
as a 2 patch series, the first for the alt_jtag_io() change, and the
other to remove all users of alt_malloc()?
thanks,
greg k-h
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] misc: altera-stapl: remove trailing semicolon in macro definition
2020-11-27 17:03 ` Greg KH
@ 2020-11-27 17:42 ` Tom Rix
0 siblings, 0 replies; 3+ messages in thread
From: Tom Rix @ 2020-11-27 17:42 UTC (permalink / raw)
To: Greg KH; +Cc: arnd, linux-kernel
On 11/27/20 9:03 AM, Greg KH wrote:
> On Fri, Nov 27, 2020 at 08:54:21AM -0800, trix@redhat.com wrote:
>> From: Tom Rix <trix@redhat.com>
>>
>> The macro use will already have a semicolon.
>>
>> Signed-off-by: Tom Rix <trix@redhat.com>
>> ---
>> drivers/misc/altera-stapl/altera-jtag.c | 4 ++--
>> 1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/drivers/misc/altera-stapl/altera-jtag.c b/drivers/misc/altera-stapl/altera-jtag.c
>> index 27e8e0c9e8cf..0238600107b0 100644
>> --- a/drivers/misc/altera-stapl/altera-jtag.c
>> +++ b/drivers/misc/altera-stapl/altera-jtag.c
>> @@ -17,9 +17,9 @@
>> #include "altera-jtag.h"
>>
>> #define alt_jtag_io(a, b, c)\
>> - astate->config->jtag_io(astate->config->dev, a, b, c);
>> + astate->config->jtag_io(astate->config->dev, a, b, c)
>>
>> -#define alt_malloc(a) kzalloc(a, GFP_KERNEL);
>> +#define alt_malloc(a) kzalloc(a, GFP_KERNEL)
> Ick, really? That macro should be removed entirely. Can you redo this
> as a 2 patch series, the first for the alt_jtag_io() change, and the
> other to remove all users of alt_malloc()?
yes.
It may be a bit, I would like to see if there are other similar wrappers.
Tom
>
> thanks,
>
> greg k-h
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-11-27 17:42 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-11-27 16:54 [PATCH] misc: altera-stapl: remove trailing semicolon in macro definition trix
2020-11-27 17:03 ` Greg KH
2020-11-27 17:42 ` Tom Rix
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox