public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: Vishawanath Jadhav <jvishwanath66@gmail.com>
Cc: linux-kernel@vger.kernel.org, surenb@google.com
Subject: Re: [PATCH] Staging: android: ashmem: Fixed a coding style issue.
Date: Sat, 28 Nov 2020 13:25:12 +0100	[thread overview]
Message-ID: <X8JBqME9UGVJBerm@kroah.com> (raw)
In-Reply-To: <20201128121627.GA27317@worker-node1>

On Sat, Nov 28, 2020 at 05:46:27PM +0530, Vishawanath Jadhav wrote:
> Fixed a coding style issue, file_operations structure should be declared as a constant.

Did you test build this change?

Also, properly wrap your changelog at 72 columns like the editor asks
you to, and use get_maintainer.pl to know who and what list to send
patches to.

thanks,

greg k-h

  reply	other threads:[~2020-11-28 21:52 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-11-28 12:16 [PATCH] Staging: android: ashmem: Fixed a coding style issue Vishawanath Jadhav
2020-11-28 12:25 ` Greg KH [this message]
2020-11-28 23:45 ` kernel test robot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=X8JBqME9UGVJBerm@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=jvishwanath66@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=surenb@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox