From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E9917C71155 for ; Sat, 28 Nov 2020 21:52:55 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id A2A0F208D5 for ; Sat, 28 Nov 2020 21:52:55 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="idFMQ6T4" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2403841AbgK1Vwy (ORCPT ); Sat, 28 Nov 2020 16:52:54 -0500 Received: from mail.kernel.org ([198.145.29.99]:50736 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1732896AbgK1TEg (ORCPT ); Sat, 28 Nov 2020 14:04:36 -0500 Received: from localhost (83-86-74-64.cable.dynamic.v4.ziggo.nl [83.86.74.64]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 8485822240; Sat, 28 Nov 2020 12:24:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1606566245; bh=6COpZqVdNAt/u2BLcs4EICsnG0a1dS0n42uvYkTvtQo=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=idFMQ6T4kBcEvnGJc+9g/5wJfLyb8m5a+J0vpFWbfADk+qFMwvJR08eo2h0ICYE5O S/Xarxay7CWh5xVBIKeykn4qCT5qmZDmOkZG6y0E57GhTO0RJz74C+9QXBFKjFNnwv 6Bu/7qQNpDeMl9/9xId8aiBodeis4+fcekwgmTDg= Date: Sat, 28 Nov 2020 13:25:12 +0100 From: Greg KH To: Vishawanath Jadhav Cc: linux-kernel@vger.kernel.org, surenb@google.com Subject: Re: [PATCH] Staging: android: ashmem: Fixed a coding style issue. Message-ID: References: <20201128121627.GA27317@worker-node1> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20201128121627.GA27317@worker-node1> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, Nov 28, 2020 at 05:46:27PM +0530, Vishawanath Jadhav wrote: > Fixed a coding style issue, file_operations structure should be declared as a constant. Did you test build this change? Also, properly wrap your changelog at 72 columns like the editor asks you to, and use get_maintainer.pl to know who and what list to send patches to. thanks, greg k-h