From: Tejun Heo <tj@kernel.org>
To: Baolin Wang <baolin.wang@linux.alibaba.com>
Cc: axboe@kernel.dk, baolin.wang7@gmail.com,
linux-block@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 3/5] blk-iocost: Move the usage ratio calculation to the correct place
Date: Wed, 2 Dec 2020 14:56:43 -0500 [thread overview]
Message-ID: <X8fxexrw/QLoqq7I@mtj.duckdns.org> (raw)
In-Reply-To: <a4e6af93419250de5372ff681d3395cf36676037.1606378475.git.baolin.wang@linux.alibaba.com>
On Thu, Nov 26, 2020 at 04:16:13PM +0800, Baolin Wang wrote:
> We only use the hweight based usage ratio to calculate the new
> hweight_inuse of the iocg to decide if this iocg can donate some
> surplus vtime.
>
> Thus move the usage ratio calculation to the correct place to
> avoid unnecessary calculation for some vtime shortage iocgs.
>
> Signed-off-by: Baolin Wang <baolin.wang@linux.alibaba.com>
Acked-by: Tejun Heo <tj@kernel.org>
Thanks.
--
tejun
next prev parent reply other threads:[~2020-12-02 19:58 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-26 8:16 [PATCH v2 0/5] Some cleanups and improvements for blk-iocost Baolin Wang
2020-11-26 8:16 ` [PATCH v2 1/5] blk-iocost: Fix some typos in comments Baolin Wang
2020-11-26 8:16 ` [PATCH v2 2/5] blk-iocost: Remove unnecessary advance declaration Baolin Wang
2020-11-26 8:16 ` [PATCH v2 3/5] blk-iocost: Move the usage ratio calculation to the correct place Baolin Wang
2020-12-02 19:56 ` Tejun Heo [this message]
2020-11-26 8:16 ` [PATCH v2 4/5] blk-iocost: Factor out the active iocgs' state check into a separate function Baolin Wang
2020-12-02 19:58 ` Tejun Heo
2020-11-26 8:16 ` [PATCH v2 5/5] blk-iocost: Factor out the base vrate change " Baolin Wang
2020-12-02 19:59 ` Tejun Heo
2020-12-07 7:19 ` [PATCH v2 0/5] Some cleanups and improvements for blk-iocost Baolin Wang
2020-12-07 15:02 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=X8fxexrw/QLoqq7I@mtj.duckdns.org \
--to=tj@kernel.org \
--cc=axboe@kernel.dk \
--cc=baolin.wang7@gmail.com \
--cc=baolin.wang@linux.alibaba.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox