From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 81EB1C4361A for ; Thu, 3 Dec 2020 15:21:36 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 2A145206D8 for ; Thu, 3 Dec 2020 15:21:36 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728467AbgLCPVf (ORCPT ); Thu, 3 Dec 2020 10:21:35 -0500 Received: from out4-smtp.messagingengine.com ([66.111.4.28]:42279 "EHLO out4-smtp.messagingengine.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726344AbgLCPVe (ORCPT ); Thu, 3 Dec 2020 10:21:34 -0500 Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailout.nyi.internal (Postfix) with ESMTP id 67EF15C0078; Thu, 3 Dec 2020 10:20:28 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute4.internal (MEProxy); Thu, 03 Dec 2020 10:20:28 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kroah.com; h= date:from:to:cc:subject:message-id:references:mime-version :content-type:in-reply-to; s=fm2; bh=eRauayqR7l9HdVQ2N0t8YYvQDNA 34Xqn4lVsuCMTxQg=; b=K80qDKiFuTzD2XY7tAh1XeR+HfgHBKbTML5YQmaiqYX Onaae3RVk1SgVeozAnUoX6koWjPwcM7mDjREhA0aDPb9A9iXfDVpO5akUrPqvFc7 KhSFx8Tg6lusmdRCDRoWNlpw3kCSGBRvo5L5Juzj5drEgz1TYCz+n34cw4pauNKn /7ZZwb7n/VNGs6rq+ZlrdO5x3UXxIAO2DpbnSgNlWlJXFKDd1d2358cAP6TJGCkv IUW0/y5nvlBT1ZDr8g8i3/NuxMcgoo2nM4lWI/XoVxHuKYB0+M7CFgDB2nlEwcuG zYaTM2hPbHQnrQQMcOoSnrOFMvlAAJjYjx7MA5fzBag== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; bh=eRauay qR7l9HdVQ2N0t8YYvQDNA34Xqn4lVsuCMTxQg=; b=rE/V9r3hxfyUPapwGq3DWn Y5chobRDzVyiDrYVPIkLye5znvqT+tiWIXe3EzzxlM+pFjQ+wxhQoyxAGGAfZviZ uHm0tpG5KbSF5be7UT8rv0Hj7kh8y62BodJb9oSfq/nnf5i2sWocdbDCAmFptU3b he1vALc0y23Yb7uV5VGVkMG6+w6+4Gfcr3PMpnKIvz0mAWOKDRY3v/O9diYGJpbw jiHO+yMp0P+cc/fDhTe3lroMiXDfI2t9OSQ38Z3pym04r92N/qNMVx5wo9LWHqg+ 7MGTcqad54EGpMNxeCxo4Gqgj0G3bNDjYH0trhTAlgPMqSltjanXJWsPfpP34+tg == X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedujedrudeiiedgjeehucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucenucfjughrpeffhffvuffkfhggtggujgesthdtre dttddtvdenucfhrhhomhepifhrvghgucfmjfcuoehgrhgvgheskhhrohgrhhdrtghomheq necuggftrfgrthhtvghrnhepveeuheejgfffgfeivddukedvkedtleelleeghfeljeeiue eggeevueduudekvdetnecukfhppeekfedrkeeirdejgedrieegnecuvehluhhsthgvrhfu ihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepghhrvghgsehkrhhorghhrdgtoh hm X-ME-Proxy: Received: from localhost (83-86-74-64.cable.dynamic.v4.ziggo.nl [83.86.74.64]) by mail.messagingengine.com (Postfix) with ESMTPA id 8B671240057; Thu, 3 Dec 2020 10:20:27 -0500 (EST) Date: Thu, 3 Dec 2020 16:21:36 +0100 From: Greg KH To: "Enrico Weigelt, metux IT consult" Cc: linux-kernel@vger.kernel.org, stern@rowland.harvard.edu, linux-usb@vger.kernel.org, usb-storage@lists.one-eyed-alien.net Subject: Re: [PATCH v2] drivers: usb: storage: prefer pr_*() macros over bare printk() Message-ID: References: <20201203141634.28850-1-info@metux.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20201203141634.28850-1-info@metux.net> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Dec 03, 2020 at 03:16:34PM +0100, Enrico Weigelt, metux IT consult wrote: > pr_*() printing helpers are preferred over using bare printk(). > > changes v2: fixed ugly typo Don't put that in the changelog, it goes below the --- line, as is documented. > > Signed-off-by: Enrico Weigelt, metux IT consult > --- > drivers/usb/storage/alauda.c | 23 ++++++++------------ > drivers/usb/storage/ene_ub6250.c | 20 ++++++++--------- > drivers/usb/storage/freecom.c | 2 +- > drivers/usb/storage/sddr09.c | 46 +++++++++++++++++----------------------- > drivers/usb/storage/sddr55.c | 7 +++--- > 5 files changed, 43 insertions(+), 55 deletions(-) > > diff --git a/drivers/usb/storage/alauda.c b/drivers/usb/storage/alauda.c > index 20b857e97e60..5806f1bee471 100644 > --- a/drivers/usb/storage/alauda.c > +++ b/drivers/usb/storage/alauda.c > @@ -622,9 +622,8 @@ static int alauda_read_map(struct us_data *us, unsigned int zone) > > /* check even parity */ > if (parity[data[6] ^ data[7]]) { > - printk(KERN_WARNING > - "alauda_read_map: Bad parity in LBA for block %d" > - " (%02X %02X)\n", i, data[6], data[7]); > + pr_warn("alauda_read_map: Bad parity in LBA for block %d" > + " (%02X %02X)\n", i, data[6], data[7]); Please use dev_warn() and friends instead. This is a driver, it has a device, it should never use "raw" printk, or pr_* calls. thanks, greg k-h