From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.0 required=3.0 tests=BAYES_00,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 21475C4361B for ; Fri, 4 Dec 2020 14:04:02 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id F0C2922A99 for ; Fri, 4 Dec 2020 14:04:01 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2388202AbgLDOEB (ORCPT ); Fri, 4 Dec 2020 09:04:01 -0500 Received: from mail-lj1-f196.google.com ([209.85.208.196]:32836 "EHLO mail-lj1-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727682AbgLDOEA (ORCPT ); Fri, 4 Dec 2020 09:04:00 -0500 Received: by mail-lj1-f196.google.com with SMTP id t22so6775664ljk.0; Fri, 04 Dec 2020 06:03:38 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=Gtn8MsRe3DMgMj91x+Smnp8eMKhG03Wope+aIlxxQKc=; b=B91VVU4A3KpJL9fLSSmOfV1L0wYc+SSiBbOa+OHF6qWPFem8RDzTBqqzAsCvrJ9eTr NZzgwmJk7UmJJBTapLvWHSamxMaqVXhwDM1lmL42m9HVU7YJsZ3CcUkqGEDGiEbnG8zj nZIqa8fvE7T2LY6bspbQxPc2JEpy40/22kzky36BdzRL1m0RDqgVdE6A+6lK0DspOhcL qEcCtkSLbYeZYJIa8nYrRMMi2dl8uyFY0RfnsBXf3bLxC+8WLTMTB5zA7cqRqVtYo+UE oPZuhGitrL+7tWDyFNpf1CHFsMPf02wGcBCoHesaULbQ8B0qL30y2erbXp4Pmeyrrp0o oIWg== X-Gm-Message-State: AOAM533FA4IMFITXBJsEjMBDIulqJS4NBLwSFkcR8taSqKBdIkEhekv7 GodnF37Avy+CU50Ko6vBcJo= X-Google-Smtp-Source: ABdhPJyVfVQdGoJLMZW3wLfqHywZjFX2O6JRGNqsqocxYouT0vH7fJrP+ILfGOn67a6g1kiOs0AAYg== X-Received: by 2002:a2e:593:: with SMTP id 141mr225913ljf.86.1607090592510; Fri, 04 Dec 2020 06:03:12 -0800 (PST) Received: from xi.terra (c-beaee455.07-184-6d6c6d4.bbcust.telenor.se. [85.228.174.190]) by smtp.gmail.com with ESMTPSA id b12sm1729780ljj.133.2020.12.04.06.03.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 04 Dec 2020 06:03:11 -0800 (PST) Received: from johan by xi.terra with local (Exim 4.93.0.4) (envelope-from ) id 1klBgX-0004KF-A2; Fri, 04 Dec 2020 15:03:45 +0100 Date: Fri, 4 Dec 2020 15:03:45 +0100 From: Johan Hovold To: Rob Herring , Greg Kroah-Hartman , Jessica Yu , Linus Torvalds Cc: Frank Rowand , Arnd Bergmann , Geert Uytterhoeven , Dmitry Torokhov , David Miller , Jakub Jelinek , Peter Zijlstra , Thomas Gleixner , Steven Rostedt , Daniel Kurtz , linux-arch@vger.kernel.org, linux-m68k@lists.linux-m68k.org, linux-kernel@vger.kernel.org, Johan Hovold Subject: Re: [PATCH v2 2/8] earlycon: simplify earlycon-table implementation Message-ID: References: <20201123102319.8090-1-johan@kernel.org> <20201123102319.8090-3-johan@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20201123102319.8090-3-johan@kernel.org> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Greg, On Mon, Nov 23, 2020 at 11:23:13AM +0100, Johan Hovold wrote: > Instead of using the array-of-pointers trick to avoid having gcc mess up > the earlycon array stride, specify type alignment when declaring entries > to prevent gcc from increasing alignment. > > This is essentially an alternative (one-line) fix to the problem > addressed by commit dd709e72cb93 ("earlycon: Use a pointer table to fix > __earlycon_table stride"). > > gcc can increase the alignment of larger objects with static extent as > an optimisation, but this can be suppressed by using the aligned > attribute when declaring variables. > > Note that we have been relying on this behaviour for kernel parameters > for 16 years and it indeed hasn't changed since the introduction of the > aligned attribute in gcc-3.1. > > Signed-off-by: Johan Hovold Could you pick this one up for 5.11? Johan