From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 29BBAC4361B for ; Wed, 9 Dec 2020 18:40:49 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id C40F92228A for ; Wed, 9 Dec 2020 18:40:48 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1733251AbgLISkJ (ORCPT ); Wed, 9 Dec 2020 13:40:09 -0500 Received: from mail.kernel.org ([198.145.29.99]:40150 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1733209AbgLISkA (ORCPT ); Wed, 9 Dec 2020 13:40:00 -0500 Date: Wed, 9 Dec 2020 19:40:33 +0100 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1607539157; bh=7B1JJYV3fj2v5nYpUV8P7FYYEngZTBSSDgmjiJpKbLA=; h=From:To:Cc:Subject:References:In-Reply-To:From; b=nNNRR+LJwYM6KxN/03T8ghHEfemVf+noQ2PNj/DDhXZEWHtNVk4DH9lJD81IK40L8 NNPJP7jY481qAikszzxsOhepRLKLPyKohAPFno67ZE7ENP6is0P0xTmTyzv1XwSBVn U98iAWUJCp5mhkN3vTTFvQt/9XX1Gt6qdKi8yw2A= From: Greg KH To: nslusarek@gmx.net Cc: jhansen@vmware.com, arnd@arndb.de, linux-kernel@vger.kernel.org Subject: Re: [PATCH] misc/vmw_vmci: bail out earlier on too big queue allocation Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Nov 22, 2020 at 06:40:57PM +0100, nslusarek@gmx.net wrote: > From: Norbert Slusarek > Date: Sun, 22 Nov 2020 19:16:41 +0100 > Subject: [PATCH] misc/vmw_vmci: bail out earlier on too big queue allocation > > For the allocation of a queue pair in qp_host_alloc_queue() an arbitrary value can be > passed for produce_size, which can lead to miscalculation of memory we'd like to allocate > in one take. A warning is triggered at __alloc_pages_nodemask() in mm/page_alloc.c:4737 > which aborts the false allocation, but it results in a VMware machine freezing > for an infinite time. > > Signed-off-by: Norbert Slusarek > Can you resend this in a non-html format, so that we can apply it, and so it will show up on the public mailing lists? thanks, greg k-h