Re: [PATCH] misc/vmw_vmci: bail out earlier on too big queue allocation

Greg KH
2020-12-09T18:41:30Z

On Wed, Dec 09, 2020 at 07:40:33PM +0100, Greg KH wrote:
> On Sun, Nov 22, 2020 at 06:40:57PM +0100, nslusarek@gmx.net wrote:
> > From: Norbert Slusarek <nslusarek@gmx.net>
> > Date: Sun, 22 Nov 2020 19:16:41 +0100
> > Subject: [PATCH] misc/vmw_vmci: bail out earlier on too big queue allocation
> >
> > For the allocation of a queue pair in qp_host_alloc_queue() an arbitrary value can be
> > passed for produce_size, which can lead to miscalculation of memory we'd like to allocate
> > in one take. A warning is triggered at __alloc_pages_nodemask() in mm/page_alloc.c:4737
> > which aborts the false allocation, but it results in a VMware machine freezing
> > for an infinite time.
> >
> > Signed-off-by: Norbert Slusarek <nslusarek@gmx.net>
> >
>
> <snip>
>
> Can you resend this in a non-html format, so that we can apply it, and
> so it will show up on the public mailing lists?

Oh nevermind, you already did, sorry about that...