From: Johan Hovold <johan@kernel.org>
To: "wanghai (M)" <wanghai38@huawei.com>
Cc: Johan Hovold <johan@kernel.org>,
vaibhav.sr@gmail.com, elder@kernel.org,
gregkh@linuxfoundation.org, dan.carpenter@oracle.com,
aibhav.sr@gmail.com, greybus-dev@lists.linaro.org,
devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: greybus: audio: Fix possible leak free widgets in gbaudio_dapm_free_controls
Date: Mon, 14 Dec 2020 10:48:27 +0100 [thread overview]
Message-ID: <X9c06wvYreO2h8uP@localhost> (raw)
In-Reply-To: <ed57715b-c524-4726-3eaf-434af96d2d92@huawei.com>
On Fri, Dec 11, 2020 at 08:29:22PM +0800, wanghai (M) wrote:
>
> 在 2020/12/8 17:35, Johan Hovold 写道:
> > On Sat, Dec 05, 2020 at 06:38:27PM +0800, Wang Hai wrote:
> >> In gbaudio_dapm_free_controls(), if one of the widgets is not found, an error
> >> will be returned directly, which will cause the rest to be unable to be freed,
> >> resulting in leak.
> >>
> >> This patch fixes the bug. If if one of them is not found, just skip and free the others.
> > Apart from the typo, please break your lines at 72 columns or so (not
> > needed for the Fixes tag).
>
> Thanks for review, Do I need to send a v2 patch to change the commit msg?
I'm not sure your mail reached the lists since it contains HTML, but to
answer your question: Please do resend. If you can make the maintainers'
life any easier that's always a good idea.
You should include the Reviewed-by tags you've gotten so far when
resending as long as you only update the commit message.
Johan
prev parent reply other threads:[~2020-12-14 9:49 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-05 10:38 [PATCH] staging: greybus: audio: Fix possible leak free widgets in gbaudio_dapm_free_controls Wang Hai
2020-12-05 14:46 ` Vaibhav Agarwal
2020-12-08 9:35 ` Johan Hovold
[not found] ` <ed57715b-c524-4726-3eaf-434af96d2d92@huawei.com>
2020-12-14 9:48 ` Johan Hovold [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=X9c06wvYreO2h8uP@localhost \
--to=johan@kernel.org \
--cc=aibhav.sr@gmail.com \
--cc=dan.carpenter@oracle.com \
--cc=devel@driverdev.osuosl.org \
--cc=elder@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=greybus-dev@lists.linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=vaibhav.sr@gmail.com \
--cc=wanghai38@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox