From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AC197C4361B for ; Tue, 15 Dec 2020 10:01:00 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 62D9622202 for ; Tue, 15 Dec 2020 10:01:00 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727843AbgLOKAw (ORCPT ); Tue, 15 Dec 2020 05:00:52 -0500 Received: from mail.kernel.org ([198.145.29.99]:33756 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726754AbgLOKAf (ORCPT ); Tue, 15 Dec 2020 05:00:35 -0500 Date: Tue, 15 Dec 2020 11:00:57 +0100 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1608026394; bh=fjSb0yXxmstyp4ZVxolAKZj+F5mcHDB/k47EK3O9bsk=; h=From:To:Cc:Subject:References:In-Reply-To:From; b=g6pVZtb9f86Sy0mgpPND3TPHRKLLDLC56gwTkdqqU+x++31C9zq3LR4bQk2fW5kAp PUZUgJS19WVqV/lLpS6Q0JFz9RdQosAwp21IGgIjcMMNTqbEcFH0UGl5xTd2+mEcgg 1pJoKu0saL+Ic8OHVCJq/Rd5+vrt3Rj+iVsXAkVQ= From: Greg Kroah-Hartman To: Shuo A Liu Cc: linux-kernel@vger.kernel.org, x86@kernel.org, "H . Peter Anvin" , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Sean Christopherson , Yu Wang , Reinette Chatre , Zhi Wang , Zhenyu Wang Subject: Re: [PATCH v6 06/18] virt: acrn: Introduce VM management interfaces Message-ID: References: <20201201093853.12070-1-shuo.a.liu@intel.com> <20201201093853.12070-7-shuo.a.liu@intel.com> <20201202021429.GL17702@shuo-intel.sh.intel.com> <20201215095259.GN17702@shuo-intel.sh.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20201215095259.GN17702@shuo-intel.sh.intel.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Dec 15, 2020 at 05:52:59PM +0800, Shuo A Liu wrote: > On Wed 2.Dec'20 at 10:14:29 +0800, Shuo A Liu wrote: > > On Tue 1.Dec'20 at 11:09:47 +0100, Greg Kroah-Hartman wrote: > > > On Tue, Dec 01, 2020 at 05:38:41PM +0800, shuo.a.liu@intel.com wrote: > > > > + vm_param->reserved0 = 0; > > > > + vm_param->reserved1 = 0; > > > > > > NO! > > > > > > This means that userspace can put whatever crud they want in those > > > fields, and you will happily zero it out. Then, when those reserved > > > fields are wanted to be used in the future, you will take those values > > > from userspace and accept them as a valid value. But, since userspace > > > was sending crud before, now you will take that crud and do something > > > with it. > > > > > > TEST IT to verify that it is zero, that way userspace gets it right the > > > first time, and you don't get it wrong later, as you can not change it > > > later. > > > > OK. Thanks for the elaboration. I will test it and return -EINVAL if > > it is not zero. > > > > Hi Greg, > > Would you like to review other patches in this series on this version? Nope, it's the middle of the merge window, I can't do anything with any new patches until after 5.11-rc1 is out. So I suggest you fix up the current issues and send a new patch series once 5.11-rc1 is released. thanks, greg k-h