From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 71BBFC4361B for ; Tue, 15 Dec 2020 21:09:38 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 3D2FE22CB8 for ; Tue, 15 Dec 2020 21:09:38 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726431AbgLOVJE (ORCPT ); Tue, 15 Dec 2020 16:09:04 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47900 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727993AbgLOVIl (ORCPT ); Tue, 15 Dec 2020 16:08:41 -0500 Received: from mail-oi1-x243.google.com (mail-oi1-x243.google.com [IPv6:2607:f8b0:4864:20::243]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8ABBAC06179C for ; Tue, 15 Dec 2020 13:07:55 -0800 (PST) Received: by mail-oi1-x243.google.com with SMTP id w124so21817786oia.6 for ; Tue, 15 Dec 2020 13:07:55 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=mr0oyFeW2WMShunStA/9/T24+fUeuQghubitiMhP6ek=; b=U+ui0jewvpcoRcg+Zyei0NVcTzeq/7RmLZqrxqmruYDpejIXqzDLBbRCjX8qpDo81Z 5LcKdpo8yz2p4NlxslHj4UgwF3+Gv72NkovkBs/Y0UyWqQaXFJVGzuM4dvBtu2E9yath VIQqW4H+0p9+IVKODH8wdHx/kCBhmakqlyBZFssmT1r9/w4lebwiwR88c4nj41Jg6ZJA Jc0LOrbT7Xi5e3zf+PynysdqdnVjhpbFjrbymsPX9bOjadywehziw6J7Mqee2VGJrcuh 7tvt+hqCIMBp5uESU611K24Dq2KSTkb12H1as9Vd53NKrJ/PStQvbAGYQkr11Xk+sbFn UBZw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=mr0oyFeW2WMShunStA/9/T24+fUeuQghubitiMhP6ek=; b=VTawHR/0s+RBwYW06PnXdM6/N1dpQuhFRFeTqB60gx3HH3xdHrqs0wKjsvENHzyX2l 25F8K5O4LgoZLRYyHEFZxuk+zkP3dogCcfziAZNAPDoUCGHsy99yBMszXnpGz/bs0Ng6 0+dzGMrp7Zo7tqnhm5U+v9oAsTIbBA4Q/0okI0pV9P8ybpwaDlQeNC4VXz1S/W7cKIdg 7hDmywYI6wRhlgqjmVSedPiDInb+CHFqp03Y2GdoIVna4rIRQClF35N6pvdgSn5LYnW0 dikyAYyqsxv/9ZbGV9n/b1q82Lyi3+ZWw5ljbhHAzZT1lPBSYG7BaQzGaPeNmu9WSGFc 1Mlw== X-Gm-Message-State: AOAM533Q/1Q7NJlCailWePjLgPOVBX8MA9RV460Hvo2Ct+/HtB1lV/+E cBS846GuE9t07laQOrY7Q/csAQ== X-Google-Smtp-Source: ABdhPJz97Uz6XziO940/hcjQxSZpaFHQuNCqrjqcaS+CKUrpBe4NMGVhAMpoNpWBYKqjXLRw2k0Qdg== X-Received: by 2002:aca:3194:: with SMTP id x142mr500622oix.82.1608066474929; Tue, 15 Dec 2020 13:07:54 -0800 (PST) Received: from builder.lan (104-57-184-186.lightspeed.austtx.sbcglobal.net. [104.57.184.186]) by smtp.gmail.com with ESMTPSA id x72sm5353148oia.16.2020.12.15.13.07.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 15 Dec 2020 13:07:54 -0800 (PST) Date: Tue, 15 Dec 2020 15:07:52 -0600 From: Bjorn Andersson To: Shawn Guo Cc: Jassi Brar , Andy Gross , Konrad Dybcio , linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] mailbox: qcom-apcs-ipc: use PLATFORM_DEVID_AUTO to register device Message-ID: References: <20201013021241.5656-1-shawn.guo@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20201013021241.5656-1-shawn.guo@linaro.org> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon 12 Oct 21:12 CDT 2020, Shawn Guo wrote: > On MSM8916, only one qcom-apcs-msm8916-clk device is needed, as there is > only one APCS clock. However, on MSM8939 three APCS clocks need to be > registered for cluster0 (little cores), cluster1 (big cores) and CCI > (Cache Coherent Interconnect). That said, we will need to register 3 > qcom-apcs-msm8916-clk devices. Let's use PLATFORM_DEVID_AUTO rather > than PLATFORM_DEVID_NONE for platform_device_register_data() call. > Otherwise, the second APCS clock registration will fail due to duplicate > device name. > > [ 0.519657] sysfs: cannot create duplicate filename '/bus/platform/devices/qcom-apcs-msm8916-clk' > ... > [ 0.661158] qcom_apcs_ipc b111000.mailbox: failed to register APCS clk > > Signed-off-by: Shawn Guo Reviewed-by: Bjorn Andersson Regards, Bjorn > --- > drivers/mailbox/qcom-apcs-ipc-mailbox.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/mailbox/qcom-apcs-ipc-mailbox.c b/drivers/mailbox/qcom-apcs-ipc-mailbox.c > index 077e5c6a9ef7..3d100a004760 100644 > --- a/drivers/mailbox/qcom-apcs-ipc-mailbox.c > +++ b/drivers/mailbox/qcom-apcs-ipc-mailbox.c > @@ -128,7 +128,7 @@ static int qcom_apcs_ipc_probe(struct platform_device *pdev) > if (apcs_data->clk_name) { > apcs->clk = platform_device_register_data(&pdev->dev, > apcs_data->clk_name, > - PLATFORM_DEVID_NONE, > + PLATFORM_DEVID_AUTO, > NULL, 0); > if (IS_ERR(apcs->clk)) > dev_err(&pdev->dev, "failed to register APCS clk\n"); > -- > 2.17.1 >