Re: [PATCH 07/11] mm: VM_BUG_ON lru page flags

Matthew Wilcox
2020-12-16T01:00:28Z

On Tue, Dec 15, 2020 at 05:54:51PM -0700, Yu Zhao wrote:
> On Mon, Dec 07, 2020 at 10:24:29PM +0000, Matthew Wilcox wrote:
> > On Mon, Dec 07, 2020 at 03:09:45PM -0700, Yu Zhao wrote:
> > > Move scattered VM_BUG_ONs to two essential places that cover all
> > > lru list additions and deletions.
> >
> > I'd like to see these converted into VM_BUG_ON_PGFLAGS so you have
> > to take that extra CONFIG step to enable checking them.
>
> Right. I'll make sure it won't slip my mind again in v2.

Hugh has enlightened me that VM_BUG_ON_PGFLAGS() should not be used for
this purpose. Sorry for the bad recommendation.