re: [PATCH] /dev/epoll update ...

[Davide Libenzi <davidel@xmailserver.org>]

On 19-Sep-2001 Dan Kegel wrote:
> Davide wrote:
> 
>> The /dev/epoll patch has been updated :
>> 
>> *) Stale events removal
>> *) Help in Configure.help ( thanks to David E. Weekly )
>> *) Fit 2.4.9
>> ...
>> http://www.xmailserver.org/linux-patches/nio-improve.html
> 
> Davide, 
> I'm getting ready to stress-test /dev/epoll finally.
> In porting my Poller_devpoll.{cc,h} to support /dev/epoll, I noticed
> the following issues:

Pls wait the end of today to let me update the patch correctly.


> 
> 2. The names made visible to userland by your patch do not follow
>    a consistent naming convention.  May I suggest that you use
>    EPOLL_ as a uniform prefix, and epoll.h as the user-visible include file?
>    http://www.opengroup.org/onlinepubs/007908799/xsh/compilation.html
>    shows that Posix cares greatly about this kind of namespace issue,
>    and it'd be nice to follow their lead, even though this isn't a Posix
>    interface.

Posix spoke :) I'll change it in the next versions.



> 3. You modify asm/poll.h.  Can your modifications be restricted to epoll.h 
>    instead?  (Hey, I don't know much, maybe there's a good reason you did this.)

This is where flags are stored and using an external file could lead to a collision
when other coders will add flags. IMHO is better to have a centralized definition
of these flags.




- Davide