From: Hamza Mahfooz <someguy@effective-light.com>
To: Peter Xu <peterx@redhat.com>
Cc: linux-kernel@vger.kernel.org, Paolo Bonzini <pbonzini@redhat.com>,
Sean Christopherson <seanjc@google.com>,
Vitaly Kuznetsov <vkuznets@redhat.com>,
Wanpeng Li <wanpengli@tencent.com>,
Jim Mattson <jmattson@google.com>, Joerg Roedel <joro@8bytes.org>,
Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
x86@kernel.org, "H. Peter Anvin" <hpa@zytor.com>,
kvm@vger.kernel.org
Subject: Re: [PATCH] KVM: const-ify all relevant uses of struct kvm_memory_slot
Date: Fri, 30 Jul 2021 16:47:57 -0400 [thread overview]
Message-ID: <XFS2XQ.ZZ0IWDD0G95J@effective-light.com> (raw)
In-Reply-To: <YQReyaxp/rwypHbR@t490s>
Hey Peter,
On Fri, Jul 30 2021 at 04:19:21 PM -0400, Peter Xu <peterx@redhat.com>
wrote:
> This patch breaks kvm/queue with above issue. Constify of
> kvm_memory_slot
> pointer should have nothing to do with this so at least it should
> need a
> separate patch. At the meantime I also don't understand why memcpy()
> here,
> which seems to be even slower..
To const-ify the slot member of struct slot_rmap_walk_iterator, we need
to
initialize a new struct and then copy it over (otherwise we would need
to relay
on casting again or the compiler will complain about it).
next prev parent reply other threads:[~2021-07-30 20:48 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-13 2:33 [PATCH] KVM: const-ify all relevant uses of struct kvm_memory_slot Hamza Mahfooz
2021-07-26 16:23 ` Paolo Bonzini
2021-07-30 20:19 ` Peter Xu
2021-07-30 20:47 ` Hamza Mahfooz [this message]
2021-07-31 4:55 ` Hamza Mahfooz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=XFS2XQ.ZZ0IWDD0G95J@effective-light.com \
--to=someguy@effective-light.com \
--cc=bp@alien8.de \
--cc=hpa@zytor.com \
--cc=jmattson@google.com \
--cc=joro@8bytes.org \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=pbonzini@redhat.com \
--cc=peterx@redhat.com \
--cc=seanjc@google.com \
--cc=tglx@linutronix.de \
--cc=vkuznets@redhat.com \
--cc=wanpengli@tencent.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox