From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Linus Walleij <linus.walleij@linaro.org>
Cc: Claudiu.Beznea@microchip.com,
linux-arm-kernel@lists.infradead.org, linux-gpio@vger.kernel.org,
linux-kernel@vger.kernel.org, Ludovic.Desroches@microchip.com,
Nicolas.Ferre@microchip.com, alexandre.belloni@bootlin.com
Subject: Re: [PATCH v3 5/5] pinctrl: at91: Utilise temporary variable for struct device
Date: Tue, 28 Feb 2023 00:20:12 +0200 [thread overview]
Message-ID: <Y/0snOSbw+oTyL65@smile.fi.intel.com> (raw)
In-Reply-To: <CACRpkdbbJUc+ciknee8puu4-gEPU+PJp3GvpJcKGiW+O0JPaWA@mail.gmail.com>
On Mon, Feb 27, 2023 at 10:44:21PM +0100, Linus Walleij wrote:
> On Fri, Feb 17, 2023 at 12:59 PM Andy Shevchenko
> <andriy.shevchenko@linux.intel.com> wrote:
> > On Fri, Feb 17, 2023 at 11:54:02AM +0000, Claudiu.Beznea@microchip.com wrote:
> > > On 15.02.2023 15:42, Andy Shevchenko wrote:
...
> > > > girq->num_parents = 1;
> > > > - girq->parents = devm_kcalloc(&pdev->dev, 1,
> > > > + girq->parents = devm_kcalloc(dev, girq->num_parents,
> > >
> > > There is still the change of the 2nd argument of devm_kcalloc() from 1 ->
> > > girq->num_parents (no functional change, though) which doesn't match the
> > > purpose of the patch and is not specified anywhere. Other than this:
> > >
> > > Reviewed-by: Claudiu Beznea <claudiu.beznea@microchip.com>
> > >
> > > > sizeof(*girq->parents),
> > > > GFP_KERNEL);
> >
n
> > Thanks for review. I have no time to fix this. So if Linus is okay to take
> > the first 4 patches, I'm fine. You or somebody else can submit an updated
> > 5th patch later on.
>
> I applied all 5 patches. The num_parents is set to 1 on the line right
> above and it's the right thing to do, and has a reviewed tag so I don't
> see the problem with this patch, let's not overinvest in process.
>
> Thanks for the very nice cleanups!
Thank you!
> I applied it locally so it won't be in linux-next until after the merge
> window closes.
--
With Best Regards,
Andy Shevchenko
prev parent reply other threads:[~2023-02-27 22:20 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-15 13:42 [PATCH v3 0/5] pinctrl: at91: Cleanups Andy Shevchenko
2023-02-15 13:42 ` [PATCH v3 1/5] pinctrl: at91: use devm_kasprintf() to avoid potential leaks (part 2) Andy Shevchenko
2023-02-15 13:42 ` [PATCH v3 2/5] pinctrl: at91: Don't mix non-devm calls with devm ones Andy Shevchenko
2023-02-15 13:42 ` [PATCH v3 3/5] pinctrl: at91: Use of_device_get_match_data() Andy Shevchenko
2023-02-15 13:42 ` [PATCH v3 4/5] pinctrl: at91: Use dev_err_probe() instead of custom messaging Andy Shevchenko
2023-02-15 13:42 ` [PATCH v3 5/5] pinctrl: at91: Utilise temporary variable for struct device Andy Shevchenko
2023-02-17 11:54 ` Claudiu.Beznea
2023-02-17 11:59 ` Andy Shevchenko
2023-02-27 21:44 ` Linus Walleij
2023-02-27 22:20 ` Andy Shevchenko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y/0snOSbw+oTyL65@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=Claudiu.Beznea@microchip.com \
--cc=Ludovic.Desroches@microchip.com \
--cc=Nicolas.Ferre@microchip.com \
--cc=alexandre.belloni@bootlin.com \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox