From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Theodore Ts'o <tytso@mit.edu>
Cc: Linus Torvalds <torvalds@linux-foundation.org>,
Greg KH <gregkh@linuxfoundation.org>,
Tharun Kumar P <tharunkumar.pasumarthi@microchip.com>,
Kumaravel Thiagarajan <kumaravel.thiagarajan@microchip.com>,
Jiri Slaby <jslaby@suse.cz>,
Stephen Rothwell <sfr@canb.auug.org.au>,
Andrew Morton <akpm@linux-foundation.org>,
linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org
Subject: Re: [GIT PULL] TTY/Serial driver updates for 6.3-rc1
Date: Tue, 28 Feb 2023 00:33:18 +0200 [thread overview]
Message-ID: <Y/0vrqZjKcAnaZAH@smile.fi.intel.com> (raw)
In-Reply-To: <Y/u59FFG+ID0OAbg@mit.edu>
On Sun, Feb 26, 2023 at 02:58:44PM -0500, Theodore Ts'o wrote:
> On Sat, Feb 25, 2023 at 06:14:11PM -0800, Linus Torvalds wrote:
> > On Sat, Feb 25, 2023 at 3:40 PM Theodore Ts'o <tytso@mit.edu> wrote:
> > >
> > > For what it's worth, in the VM world (e.g., qemu, AWS, GCP, Azure,
> > > Linode, etc.) serial consoles are quite common way of debugging VM's,
> > > and as an emergency login path when the networking has been screwed up
> > > for some reason....
> >
> > Everybody seems to be missing the point.
> >
> > We don't make new drivers "default y" (or, in this case, "default SERIAL_8250".
> >
> > It does not matter ONE WHIT if you have a serial device in your
> > machine. If your old driver was enabled and worked for you and you
> > used it daily, that is ENTIRELY IMMATERIAL to a new driver, even if
> > that new driver then happens to use some of the same infrastructure as
> > the old one did.
>
> Oh, agreed, I wasn't responding to that part of your message. New
> serial drivers should never be enabled by default.
+1 here. I don't know how I missed that during review.
Some of the "new" (not really, the split of the 8250_pci) drivers
I made in the past inherited that so user won't see the change
(sudden disappearance of the console w/o touching defconfig).
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2023-02-27 22:38 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-24 12:51 [GIT PULL] TTY/Serial driver updates for 6.3-rc1 Greg KH
2023-02-24 21:15 ` pr-tracker-bot
2023-02-24 21:24 ` Linus Torvalds
2023-02-24 21:30 ` Linus Torvalds
2023-02-24 22:32 ` Al Viro
2023-02-24 22:57 ` Linus Torvalds
2023-02-25 23:40 ` Theodore Ts'o
2023-02-26 2:14 ` Linus Torvalds
2023-02-26 6:50 ` Greg KH
2023-02-27 19:54 ` Tharunkumar.Pasumarthi
2023-02-28 7:35 ` Greg KH
2023-02-26 19:58 ` Theodore Ts'o
2023-02-27 22:33 ` Andy Shevchenko [this message]
2023-02-27 22:47 ` Linus Torvalds
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y/0vrqZjKcAnaZAH@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=akpm@linux-foundation.org \
--cc=gregkh@linuxfoundation.org \
--cc=jslaby@suse.cz \
--cc=kumaravel.thiagarajan@microchip.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=sfr@canb.auug.org.au \
--cc=tharunkumar.pasumarthi@microchip.com \
--cc=torvalds@linux-foundation.org \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox