From: Mehdi Djait <mehdi.djait.k@gmail.com>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: jic23@kernel.org, lars@metafoo.de, linux-iio@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] iio: Improve the kernel-doc of iio_trigger_poll
Date: Tue, 28 Feb 2023 20:16:57 +0100 [thread overview]
Message-ID: <Y/5TKSylDDT74YBT@carbian> (raw)
In-Reply-To: <Y/0znth++tPsptKs@smile.fi.intel.com>
Hello Andy,
On Tue, Feb 28, 2023 at 12:50:06AM +0200, Andy Shevchenko wrote:
> On Mon, Feb 27, 2023 at 07:00:38PM +0100, Mehdi Djait wrote:
> > Move the kernel-doc of the function to industrialio-trigger.c
> > Add a note on the context where the function is expected to be called.
>
> ...
>
> > + * This function needs to be called from an interrupt context.
>
> > - * Typically called in relevant hardware interrupt handler.
>
> These are not equivalent. Can you explain in the commit message why we move
> from hardware to any interrupt context?
I read the definition of handle_irq_desc more carefully and [1]. I will
change it to hard IRQ context.
I got confused by the kernel-docs under /kernel/irq/irqdesc.c as it states
that the function must be called from an IRQ context for generic_handle_irq
but explicitly states hard IRQ context for another funtion.
[1] https://lore.kernel.org/all/1346922337-17088-1-git-send-email-lars@metafoo.de/
--
Kind Regards
Mehdi Djait
next prev parent reply other threads:[~2023-02-28 19:17 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-27 18:00 [PATCH 0/2] iio: Add kernel-doc and rename Mehdi Djait
2023-02-27 18:00 ` [PATCH 1/2] iio: Improve the kernel-doc of iio_trigger_poll Mehdi Djait
2023-02-27 22:50 ` Andy Shevchenko
2023-02-28 19:16 ` Mehdi Djait [this message]
2023-02-27 18:00 ` [PATCH 2/2] iio: Rename iio_trigger_poll_chained and add kernel-doc Mehdi Djait
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y/5TKSylDDT74YBT@carbian \
--to=mehdi.djait.k@gmail.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=jic23@kernel.org \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox