From: "Theodore Ts'o" <tytso@mit.edu>
To: Ritesh Harjani <ritesh.list@gmail.com>
Cc: Kemeng Shi <shikemeng@huaweicloud.com>,
adilger.kernel@dilger.ca, jack@suse.cz, ojaswin@linux.ibm.com,
linux-ext4@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 00/20] Some bugfix and cleanup to mballoc
Date: Tue, 28 Feb 2023 17:30:25 -0500 [thread overview]
Message-ID: <Y/6AgYotmMdjei3w@mit.edu> (raw)
In-Reply-To: <87356pwxyc.fsf@doe.com>
On Tue, Feb 28, 2023 at 10:04:35PM +0530, Ritesh Harjani wrote:
> Kemeng Shi <shikemeng@huaweicloud.com> writes:
>
> > Hi, this series contain some random cleanup patches and some bugfix
> > patches to make EXT4_MB_HINT_GOAL_ONLY work properly, protect pa->pa_free
> > from race and so on. More details can be found in git log.
> > Thanks!
>
> Hi Kemeng,
>
> Did you run any testing on these patches? Because I was very easily able
> to hit ext/009 causing kernel BUG_ON with default mkfs/mount options.
> It's always a good and recommended practice to ensure some level of
> testing on any of the patches we submit to community for review
> and call out in the cover letter on what has been tested and what is not.
Hi Kemeng,
If you need help running xfstests, I maintain a test appliance which
makes it very easy to run xfstests on development kernels. Please see:
https://github.com/tytso/xfstests-bld/blob/master/Documentation/kvm-xfstests.md
https://github.com/tytso/xfstests-bld/blob/master/Documentation/kvm-quickstart.md
This test appliance can also be run on Android devices and using
Google Compute Engine; for more information see:
https://thunk.org/android-xfstests
https://thunk.org/gce-xfstests
If you're just getting started, I recommend that you start with
kvm-xfstests, and this is the simplest way to get started.
Cheers,
- Ted
next prev parent reply other threads:[~2023-02-28 22:32 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-28 11:42 [PATCH v2 00/20] Some bugfix and cleanup to mballoc Kemeng Shi
2023-02-28 11:42 ` [PATCH v2 01/20] ext4: set goal start correctly in ext4_mb_normalize_request Kemeng Shi
2023-02-28 11:42 ` [PATCH v2 02/20] ext4: allow to find by goal if EXT4_MB_HINT_GOAL_ONLY is set Kemeng Shi
2023-02-28 11:42 ` [PATCH v2 03/20] ext4: get correct ext4_group_info in ext4_mb_prefetch_fini Kemeng Shi
2023-02-28 11:42 ` [PATCH v2 04/20] ext4: correct calculation of s_mb_preallocated Kemeng Shi
2023-02-28 11:42 ` [PATCH v2 05/20] ext4: correct start of used group pa for debug in ext4_mb_use_group_pa Kemeng Shi
2023-02-28 11:42 ` [PATCH v2 06/20] ext4: protect pa->pa_free in ext4_discard_allocated_blocks Kemeng Shi
2023-02-28 11:42 ` [PATCH v2 07/20] ext4: add missed brelse in ext4_free_blocks_simple Kemeng Shi
2023-02-28 11:42 ` [PATCH v2 08/20] ext4: remove unused return value of ext4_mb_try_best_found and ext4_mb_free_metadata Kemeng Shi
2023-02-28 11:42 ` [PATCH v2 09/20] ext4: Remove unnecessary release when memory allocation failed in ext4_mb_init_cache Kemeng Shi
2023-02-28 11:42 ` [PATCH v2 10/20] ext4: remove unnecessary e4b->bd_buddy_page check in ext4_mb_load_buddy_gfp Kemeng Shi
2023-02-28 11:42 ` [PATCH v2 11/20] ext4: remove unnecessary check in ext4_mb_new_blocks Kemeng Shi
2023-02-28 11:42 ` [PATCH v2 12/20] ext4: remove dead check in mb_buddy_mark_free Kemeng Shi
2023-02-28 11:42 ` [PATCH v2 13/20] ext4: remove ac->ac_found > sbi->s_mb_min_to_scan dead check in ext4_mb_check_limits Kemeng Shi
2023-02-28 11:43 ` [PATCH v2 14/20] ext4: use best found when complex scan of group finishs Kemeng Shi
2023-02-28 11:43 ` [PATCH v2 15/20] ext4: remove unnecessary exit_meta_group_info tag Kemeng Shi
2023-02-28 11:43 ` [PATCH v2 16/20] ext4: remove unnecessary count2 in ext4_free_data_in_buddy Kemeng Shi
2023-02-28 11:43 ` [PATCH v2 17/20] ext4: remove unnecessary goto in ext4_mb_mark_diskspace_used Kemeng Shi
2023-02-28 11:43 ` [PATCH v2 18/20] ext4: remove repeat assignment to ac_f_ex Kemeng Shi
2023-02-28 11:43 ` [PATCH v2 19/20] ext4: remove comment code ext4_discard_preallocations Kemeng Shi
2023-02-28 11:43 ` [PATCH v2 20/20] ext4: simplify calculation of blkoff in ext4_mb_new_blocks_simple Kemeng Shi
2023-02-28 16:34 ` [PATCH v2 00/20] Some bugfix and cleanup to mballoc Ritesh Harjani
2023-02-28 22:30 ` Theodore Ts'o [this message]
2023-03-01 1:28 ` Kemeng Shi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y/6AgYotmMdjei3w@mit.edu \
--to=tytso@mit.edu \
--cc=adilger.kernel@dilger.ca \
--cc=jack@suse.cz \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=ojaswin@linux.ibm.com \
--cc=ritesh.list@gmail.com \
--cc=shikemeng@huaweicloud.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox