From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id BA5C5C64ED6 for ; Sat, 18 Feb 2023 10:29:34 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229897AbjBRK3d (ORCPT ); Sat, 18 Feb 2023 05:29:33 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36542 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229476AbjBRK3b (ORCPT ); Sat, 18 Feb 2023 05:29:31 -0500 Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com [66.111.4.25]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A12491ADFA; Sat, 18 Feb 2023 02:29:30 -0800 (PST) Received: from compute2.internal (compute2.nyi.internal [10.202.2.46]) by mailout.nyi.internal (Postfix) with ESMTP id 9955F5C00DE; Sat, 18 Feb 2023 05:29:27 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute2.internal (MEProxy); Sat, 18 Feb 2023 05:29:27 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kroah.com; h=cc :cc:content-type:date:date:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to; s=fm1; t=1676716167; x=1676802567; bh=z7pNc7FSy/ sM7V64UiBjw0RNRZzP3TFT4yJbRpLVQck=; b=ao4LI3p2TocAOyfJ+ZzxJbHYkM ldqO3P9ax0qEUturXm+56E5YhpddYVN0EP6amx0ZbTJeRJsg2DK+EE7YY1hpXxyf 4UQdB+RPW8+Xpw8KJuQbqWKm2NAHJtmLarm4V0sZVXtZudY7omz+tjumusV8bC3C Qfu6aEo8Q/Tzl2b8QjsfljkrpiIXn3oYSh2E5D6Kk8qxBmajSWu+g//ZWgdnPi9K o82uarqfFFnJvQiaBFnBpNI1BWw6tzM5B5Df1BMperySMK49F0cfs44ab3tg80VO AprBWCo88VC4IfU8ltGAoWenc8pM1rIiplMFP3xO9a66Xt+81FADCHK7UWuQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:date:date:feedback-id :feedback-id:from:from:in-reply-to:in-reply-to:message-id :mime-version:references:reply-to:sender:subject:subject:to:to :x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm1; t=1676716167; x=1676802567; bh=z7pNc7FSy/sM7V64UiBjw0RNRZzP 3TFT4yJbRpLVQck=; b=cXuL0PJ5MID+F9HeeTemXNzUdzOIEIfJbB7hCGAOH0XP tKiqpHlU+3lpb7ZvzhS/9CVlNEKsAk0w1WmwbBm5h1sdSLUd8USBaw1BimnJ+2Ip hjqndKWPlRUr3DypLt6zgRlXSrvQYaUWuDqZ5NkgXMowTC1rO+Q/dRCifpGgGOQH UI0Q6MnIelED/7hj06uVk5bYN0rmKl51sZYFEx4PRwsiGkkKrFpWlavvfAx7yQGz lde27GUVXdPlEJYgqVEvVvq6VWWDzgcTaIWhHJ9iHXIE/waCelwzcX0wHcEb+PC5 e6ansvlaPgly7VfIhogOjsEl8v21GWezlLnsR0Opmw== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedrudejuddgudehucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucenucfjughrpeffhffvvefukfhfgggtuggjsehttd ertddttddvnecuhfhrohhmpefirhgvghcumffjuceoghhrvghgsehkrhhorghhrdgtohhm qeenucggtffrrghtthgvrhhnpeegheeuhefgtdeluddtleekfeegjeetgeeikeehfeduie ffvddufeefleevtddtvdenucffohhmrghinhepkhgvrhhnvghlrdhorhhgnecuvehluhhs thgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepghhrvghgsehkrhhorg hhrdgtohhm X-ME-Proxy: Feedback-ID: i787e41f1:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Sat, 18 Feb 2023 05:29:26 -0500 (EST) Date: Sat, 18 Feb 2023 11:29:24 +0100 From: Greg KH To: Andrew Paniakin Cc: stable@vger.kernel.org, luizcap@amazon.com, keescook@chromium.org, shuah@kernel.org, linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [5.15] Please apply 'selftest/lkdtm: Skip stack-entropy test if lkdtm is not available' Message-ID: References: <20230217221705.2525177-1-apanyaki@amazon.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230217221705.2525177-1-apanyaki@amazon.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Feb 17, 2023 at 02:17:05PM -0800, Andrew Paniakin wrote: > commit 90091c367e74d5b58d9ebe979cc363f7468f58d3 upstream. > > This patch fixes the stack-entropy.sh test to exit gracefully when the LKDTM is > not available. Test will hang otherwise as reported in [1]. > > Applicability of this fix to other LTS kernels: > - 4.14: No lkdtm selftest > - 4.19: No lkdtm selftest > - 5.4: No lkdtm selftests > - 5.10: Inital selftest version introduced in 46d1a0f03d661 ("selftests/lkdtm: > Add tests for LKDTM targets") is a single script which has the LKDTM > availability check > - 6.1: Fix applied > > This patch applies cleanly to stable-5.15 tree. Updated test was executed in > Qemu VM with different kernels: > - CONFIG_LKDTM not enabled. Test finished with status SKIP. > - CONFIG_LKDTM enabled. Test failed (but not hanged) with error 'Stack entropy > is low'. > - CONFIG_LKDTM enabled and randomize_kstack_offset=on boot argument provided. > Test succeed. > > [1] https://lore.kernel.org/lkml/2836f48a-d4e2-7f00-f06c-9f556fbd6332@linuxfoundation.org Now queued up, thanks. greg k-h