Re: [ PATCH v4 6/6] sign-file: improve help message

David Howells
2023-03-14T16:28:12Z

Shreenidhi Shedi <yesshedi@gmail.com> wrote:

> + exit(retval);

Should be "exit(2)".

> + fprintf(stderr, "\nExamples:\n");
> +
> + fprintf(stderr, "\nRegular signing:\n");

You need to distinguish the two lines as they both look like headings when one
is actually a subheading of the other.

> + fprintf(stderr, "scripts/sign-file -a sha512 -p certs/signing_key.pem ");
> + fprintf(stderr, "-x certs/signing_key.x509 <module>\n");

David