From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id D446AC61DA3 for ; Tue, 21 Feb 2023 15:09:17 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234205AbjBUPJQ (ORCPT ); Tue, 21 Feb 2023 10:09:16 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33518 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233278AbjBUPJO (ORCPT ); Tue, 21 Feb 2023 10:09:14 -0500 Received: from desiato.infradead.org (desiato.infradead.org [IPv6:2001:8b0:10b:1:d65d:64ff:fe57:4e05]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9914BB474; Tue, 21 Feb 2023 07:09:04 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=desiato.20200630; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=hgiqFcrHrTOErRluuJ8EB5lE7JskCeix2FOR6T4RAXM=; b=Hi5kfNI2kxEJjzN24oHOhV2D/I +4VjRZJ2X2mYpVBtbjR3AiN2kZfCQ0W4hnWSt/Z3eAr36X+lH9yPwAEBaRLcAUL79PJXvn2VUyFJi vic7vETHl1ZcQK2IXt7mQi2IT+PBL0delArNyV9UhYFTSDzFQmZ/xf34ciFvXV2gAbthqaUmfGzhW HmXblbalNa+HLd7MQigDMeRLgE1a0EHMrERCeei6wKb+wN+Cv6Fy0Ero0i3WoVKrtOJXHWSOJWacA DQT7GRrrnxjH6QaKqTPj3bMOgljcx3uD7R4fFdJc0zNX1A/r2pSNRn8/MJ+433PsUI3Aewg5C3OmK i+/c0aqQ==; Received: from j130084.upc-j.chello.nl ([24.132.130.84] helo=noisy.programming.kicks-ass.net) by desiato.infradead.org with esmtpsa (Exim 4.96 #2 (Red Hat Linux)) id 1pUUFv-00CCBf-1Q; Tue, 21 Feb 2023 15:08:35 +0000 Received: from hirez.programming.kicks-ass.net (hirez.programming.kicks-ass.net [192.168.1.225]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by noisy.programming.kicks-ass.net (Postfix) with ESMTPS id E51D13003E1; Tue, 21 Feb 2023 16:08:33 +0100 (CET) Received: by hirez.programming.kicks-ass.net (Postfix, from userid 1000) id C8E4820084269; Tue, 21 Feb 2023 16:08:33 +0100 (CET) Date: Tue, 21 Feb 2023 16:08:33 +0100 From: Peter Zijlstra To: Vincent Guittot Cc: mingo@redhat.com, juri.lelli@redhat.com, dietmar.eggemann@arm.com, rostedt@goodmis.org, bsegall@google.com, mgorman@suse.de, bristot@redhat.com, vschneid@redhat.com, linux-kernel@vger.kernel.org, parth@linux.ibm.com, cgroups@vger.kernel.org, qyousef@layalina.io, chris.hyser@oracle.com, patrick.bellasi@matbug.net, David.Laight@aculab.com, pjt@google.com, pavel@ucw.cz, tj@kernel.org, qperret@google.com, tim.c.chen@linux.intel.com, joshdon@google.com, timj@gnu.org, kprateek.nayak@amd.com, yu.c.chen@intel.com, youssefesmat@chromium.org, joel@joelfernandes.org Subject: Re: [PATCH v10 5/9] sched/fair: Take into account latency priority at wakeup Message-ID: References: <20230113141234.260128-1-vincent.guittot@linaro.org> <20230113141234.260128-6-vincent.guittot@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Feb 21, 2023 at 03:21:54PM +0100, Vincent Guittot wrote: > On Tue, 21 Feb 2023 at 14:05, Peter Zijlstra wrote: > > Should we perhaps also do this for latency_nice == 0?, in any case I > > think this can be moved to its own patch to avoid doing too much in the > > one patch. It seems fairly self contained. > > This function is then removed by patch 9 as the additional rb tree > fixes all cases Also, since you remove it again later, perhaps not introduce it at all?