From: Peter Zijlstra <peterz@infradead.org>
To: Vincent Guittot <vincent.guittot@linaro.org>
Cc: mingo@redhat.com, juri.lelli@redhat.com,
dietmar.eggemann@arm.com, rostedt@goodmis.org,
bsegall@google.com, mgorman@suse.de, bristot@redhat.com,
vschneid@redhat.com, linux-kernel@vger.kernel.org,
parth@linux.ibm.com, cgroups@vger.kernel.org,
qyousef@layalina.io, chris.hyser@oracle.com,
patrick.bellasi@matbug.net, David.Laight@aculab.com,
pjt@google.com, pavel@ucw.cz, tj@kernel.org, qperret@google.com,
tim.c.chen@linux.intel.com, joshdon@google.com, timj@gnu.org,
kprateek.nayak@amd.com, yu.c.chen@intel.com,
youssefesmat@chromium.org, joel@joelfernandes.org
Subject: Re: [PATCH v10 8/9] sched/fair: Add latency list
Date: Tue, 21 Feb 2023 16:11:51 +0100 [thread overview]
Message-ID: <Y/TfN1upxApdSERP@hirez.programming.kicks-ass.net> (raw)
In-Reply-To: <20230113141234.260128-9-vincent.guittot@linaro.org>
On Fri, Jan 13, 2023 at 03:12:33PM +0100, Vincent Guittot wrote:
> @@ -12552,8 +12634,15 @@ int sched_group_set_latency(struct task_group *tg, s64 latency)
>
> for_each_possible_cpu(i) {
> struct sched_entity *se = tg->se[i];
> + struct rq *rq = cpu_rq(i);
> + struct rq_flags rf;
> +
> + rq_lock_irqsave(rq, &rf);
>
> + __dequeue_latency(se->cfs_rq, se);
> WRITE_ONCE(se->latency_offset, latency);
> +
> + rq_unlock_irqrestore(rq, &rf);
> }
This seems asymmetric; maybe something like:
queued = __dequeue_latency(..);
WRITE_ONCE(...);
if (queued)
__enqueue_latency(...);
?
next prev parent reply other threads:[~2023-02-21 15:12 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-13 14:12 [PATCH v10 0/9] Add latency priority for CFS class Vincent Guittot
2023-01-13 14:12 ` [PATCH v10 1/9] sched/fair: fix unfairness at wakeup Vincent Guittot
2023-01-13 14:12 ` [PATCH v10 2/9] sched: Introduce latency-nice as a per-task attribute Vincent Guittot
2023-01-13 14:12 ` [PATCH v10 3/9] sched/core: Propagate parent task's latency requirements to the child task Vincent Guittot
2023-01-13 14:12 ` [PATCH v10 4/9] sched: Allow sched_{get,set}attr to change latency_nice of the task Vincent Guittot
2023-01-13 14:12 ` [PATCH v10 5/9] sched/fair: Take into account latency priority at wakeup Vincent Guittot
2023-02-21 12:52 ` Peter Zijlstra
2023-02-21 14:12 ` Vincent Guittot
2023-02-21 14:15 ` Peter Zijlstra
2023-02-21 14:25 ` Vincent Guittot
2023-02-21 13:04 ` Peter Zijlstra
2023-02-21 14:21 ` Vincent Guittot
2023-02-21 14:51 ` Peter Zijlstra
2023-02-21 15:08 ` Peter Zijlstra
2023-02-21 15:34 ` Vincent Guittot
2023-01-13 14:12 ` [PATCH v10 6/9] sched/fair: Add sched group latency support Vincent Guittot
2023-02-21 15:01 ` Peter Zijlstra
2023-02-21 15:32 ` Vincent Guittot
2023-01-13 14:12 ` [PATCH v10 7/9] sched/core: Support latency priority with sched core Vincent Guittot
2023-01-13 14:12 ` [PATCH v10 8/9] sched/fair: Add latency list Vincent Guittot
2023-02-21 15:11 ` Peter Zijlstra [this message]
2023-02-21 15:42 ` Vincent Guittot
2023-02-22 9:49 ` Peter Zijlstra
2023-02-22 11:16 ` Vincent Guittot
2023-02-27 13:29 ` Peter Zijlstra
2023-02-27 14:55 ` Vincent Guittot
2023-01-13 14:12 ` [PATCH v10 9/9] sched/fair: remove check_preempt_from_others Vincent Guittot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y/TfN1upxApdSERP@hirez.programming.kicks-ass.net \
--to=peterz@infradead.org \
--cc=David.Laight@aculab.com \
--cc=bristot@redhat.com \
--cc=bsegall@google.com \
--cc=cgroups@vger.kernel.org \
--cc=chris.hyser@oracle.com \
--cc=dietmar.eggemann@arm.com \
--cc=joel@joelfernandes.org \
--cc=joshdon@google.com \
--cc=juri.lelli@redhat.com \
--cc=kprateek.nayak@amd.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mgorman@suse.de \
--cc=mingo@redhat.com \
--cc=parth@linux.ibm.com \
--cc=patrick.bellasi@matbug.net \
--cc=pavel@ucw.cz \
--cc=pjt@google.com \
--cc=qperret@google.com \
--cc=qyousef@layalina.io \
--cc=rostedt@goodmis.org \
--cc=tim.c.chen@linux.intel.com \
--cc=timj@gnu.org \
--cc=tj@kernel.org \
--cc=vincent.guittot@linaro.org \
--cc=vschneid@redhat.com \
--cc=youssefesmat@chromium.org \
--cc=yu.c.chen@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox