From: Sean Christopherson <seanjc@google.com>
To: Binbin Wu <binbin.wu@linux.intel.com>
Cc: linux-kernel@vger.kernel.org, kvm@vger.kernel.org, pbonzini@redhat.com
Subject: Re: [PATCH] KVM: x86: Remove duplicated calls of reverse_cpuid_check()
Date: Tue, 21 Feb 2023 07:54:20 -0800 [thread overview]
Message-ID: <Y/TpLMRiNwGt2dhY@google.com> (raw)
In-Reply-To: <20230221032156.791-1-binbin.wu@linux.intel.com>
On Tue, Feb 21, 2023, Binbin Wu wrote:
> Remove duplicated calls of reverse_cpuid_check() in __kvm_cpu_cap_mask()
> and kvm_cpu_cap_{clear, set, get}().
I want to keep the checks even though they are redundant. There is no runtime
cost, and the intent of the direct calls in the "upper" helpers is as much to
document their usage constraints (input feature must be a compile-time constant)
as it is to enforce correctness.
next prev parent reply other threads:[~2023-02-21 15:54 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-21 3:21 [PATCH] KVM: x86: Remove duplicated calls of reverse_cpuid_check() Binbin Wu
2023-02-21 15:54 ` Sean Christopherson [this message]
2023-02-22 2:38 ` Binbin Wu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y/TpLMRiNwGt2dhY@google.com \
--to=seanjc@google.com \
--cc=binbin.wu@linux.intel.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pbonzini@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox