From: William Breathitt Gray <william.gray@linaro.org>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: Mark Brown <broonie@kernel.org>,
Aidan MacDonald <aidanmacdonald.0x0@gmail.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 1/1] regmap-irq: Place kernel doc of struct regmap_irq_chip in order
Date: Wed, 22 Feb 2023 12:46:05 -0500 [thread overview]
Message-ID: <Y/ZU3YWmC+/sN2iq@fedora> (raw)
In-Reply-To: <Y/e19Oqf1XwDo/aw@smile.fi.intel.com>
[-- Attachment #1: Type: text/plain, Size: 1223 bytes --]
On Thu, Feb 23, 2023 at 08:52:36PM +0200, Andy Shevchenko wrote:
> On Wed, Feb 22, 2023 at 11:43:28AM -0500, William Breathitt Gray wrote:
> > On Mon, Feb 20, 2023 at 05:33:34PM +0200, Andy Shevchenko wrote:
> > > unsigned int use_ack:1;
> > > unsigned int ack_invert:1;
> > > unsigned int clear_ack:1;
> > > + unsigned int status_invert:1;
> > > unsigned int wake_invert:1;
> > > - unsigned int runtime_pm:1;
> > > unsigned int type_in_mask:1;
> > > unsigned int clear_on_unmask:1;
> > > + unsigned int runtime_pm:1;
> > > unsigned int not_fixed_stride:1;
> > > - unsigned int status_invert:1;
> >
> > These don't look alphabetical, so what is the order for these?
>
> Nope, the order is to follow:
> a) kernel doc
> b) semantics of each of the groups
>
> Do you think the order can be improved? Can you point out how?
No, I don't have any particular improvement suggestions, I'm just want
to understand the current order for when I introduce something new here
(e.g. no_status). If I understand correctly, status_invert was moved up
to be with the other "*_invert" flags, but why was runtime_pm moved
to above not_fixed_stride rather than below it?
William Breathitt Gray
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
next prev parent reply other threads:[~2023-02-23 22:26 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-20 15:33 [PATCH v2 1/1] regmap-irq: Place kernel doc of struct regmap_irq_chip in order Andy Shevchenko
2023-02-22 16:43 ` William Breathitt Gray
2023-02-23 18:52 ` Andy Shevchenko
2023-02-22 17:46 ` William Breathitt Gray [this message]
2023-02-24 15:01 ` Andy Shevchenko
2023-02-22 19:24 ` William Breathitt Gray
2023-02-24 16:36 ` Andy Shevchenko
2023-03-06 14:09 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y/ZU3YWmC+/sN2iq@fedora \
--to=william.gray@linaro.org \
--cc=aidanmacdonald.0x0@gmail.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=broonie@kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox