From: Matthias Kaehlcke <mka@chromium.org>
To: Stephen Boyd <swboyd@chromium.org>
Cc: Liam Girdwood <lgirdwood@gmail.com>,
Mark Brown <broonie@kernel.org>,
Douglas Anderson <dianders@chromium.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] regulator: core: Use ktime_get_boottime() to determine how long a regulator was off
Date: Thu, 23 Feb 2023 00:05:37 +0000 [thread overview]
Message-ID: <Y/at0SrG+q2AOtuZ@google.com> (raw)
In-Reply-To: <CAE-0n51P-nXPKmcN9K5RtdFJh5EQ3M_hm2LjBicfegWKUda2Dw@mail.gmail.com>
On Wed, Feb 22, 2023 at 03:46:39PM -0500, Stephen Boyd wrote:
> Quoting Matthias Kaehlcke (2023-02-22 11:15:46)
> > For regulators with 'off-on-delay-us' the regulator framework currently
> > uses ktime_get() to determine how long the regulator has been off
> > before re-enabling it (after a delay if needed). A problem with using
> > ktime_get() is that it doesn't account for the time the system is
> > suspended. As a result a regulator with a longer 'off-on-delay' (e.g.
> > 500ms) that was switched off during suspend might still incurr in a
> > delay on resume before it is re-enabled, even though the regulator
> > might have been off for hours. ktime_get_boottime() accounts for
> > suspend time, use it instead of ktime_get().
> >
> > Signed-off-by: Matthias Kaehlcke <mka@chromium.org>
> > ---
>
> Is it fixing something in stable kernels? Should it be tagged for
> stable?
It's not a super-critical fix, but it could improve resume time for
some devices with stable kernels, so it might be worth adding it to
stable. I'll send out a a v2 with the corresponding tags.
prev parent reply other threads:[~2023-02-23 0:05 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-22 19:15 [PATCH] regulator: core: Use ktime_get_boottime() to determine how long a regulator was off Matthias Kaehlcke
2023-02-22 20:46 ` Stephen Boyd
2023-02-23 0:05 ` Matthias Kaehlcke [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y/at0SrG+q2AOtuZ@google.com \
--to=mka@chromium.org \
--cc=broonie@kernel.org \
--cc=dianders@chromium.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=swboyd@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox