From: Lee Jones <lee@kernel.org>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: Okan Sahin <okan.sahin@analog.com>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Liam Girdwood <lgirdwood@gmail.com>,
Mark Brown <broonie@kernel.org>,
Jonathan Cameron <jic23@kernel.org>,
Lars-Peter Clausen <lars@metafoo.de>,
Geert Uytterhoeven <geert+renesas@glider.be>,
ChiYuan Huang <cy_huang@richtek.com>,
Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>,
William Breathitt Gray <william.gray@linaro.org>,
Ramona Bolboaca <ramona.bolboaca@analog.com>,
Caleb Connolly <caleb.connolly@linaro.org>,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-iio@vger.kernel.org
Subject: Re: [PATCH v5 5/5] mfd: max77541: Add ADI MAX77541/MAX77540 PMIC Support
Date: Thu, 23 Feb 2023 14:00:15 +0000 [thread overview]
Message-ID: <Y/dxb+PTm4ry3Bss@google.com> (raw)
In-Reply-To: <Y/Y/Tv9CxgRkNESv@smile.fi.intel.com>
On Wed, 22 Feb 2023, Andy Shevchenko wrote:
> On Wed, Feb 22, 2023 at 03:32:55PM +0000, Lee Jones wrote:
> > On Tue, 21 Feb 2023, Andy Shevchenko wrote:
> > > On Tue, Feb 21, 2023 at 01:39:13PM +0300, Okan Sahin wrote:
>
> ...
>
> > > > +#ifndef __MAX77541_MFD_H__
> > > > +#define __MAX77541_MFD_H__
> > >
> > > Can we go towards consistency in this?
> > > Seems to me the most used patter so far is
> > >
> > > #ifndef __LINUX_MFD_MAX77541_H
> >
> > Drop the LINUX_ part please.
>
> Wouldn't be better to get rid of its usage at once?
> Perhaps after v6.3-rc1 is out.
Patches always welcome.
--
Lee Jones [李琼斯]
prev parent reply other threads:[~2023-02-23 14:00 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-21 10:39 [PATCH v5 0/5] Add MAX77541/MAX77540 PMIC Support Okan Sahin
2023-02-21 10:39 ` [PATCH v5 1/5] dt-bindings: regulator: max77541: Add ADI MAX77541/MAX77540 Regulator Okan Sahin
2023-02-21 10:39 ` [PATCH v5 2/5] regulator: max77541: Add ADI MAX77541/MAX77540 Regulator Support Okan Sahin
2023-02-21 12:18 ` Andy Shevchenko
2023-02-21 10:39 ` [PATCH v5 3/5] iio: adc: max77541: Add ADI MAX77541 ADC Support Okan Sahin
2023-02-21 11:59 ` Andy Shevchenko
2023-02-21 10:39 ` [PATCH v5 4/5] dt-bindings: mfd: max77541: Add ADI MAX77541/MAX77540 Okan Sahin
2023-02-21 11:21 ` Krzysztof Kozlowski
2023-02-21 10:39 ` [PATCH v5 5/5] mfd: max77541: Add ADI MAX77541/MAX77540 PMIC Support Okan Sahin
2023-02-21 12:13 ` Andy Shevchenko
2023-02-22 15:32 ` Lee Jones
2023-02-22 16:14 ` Andy Shevchenko
2023-02-23 14:00 ` Lee Jones [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y/dxb+PTm4ry3Bss@google.com \
--to=lee@kernel.org \
--cc=andriy.shevchenko@linux.intel.com \
--cc=broonie@kernel.org \
--cc=caleb.connolly@linaro.org \
--cc=cy_huang@richtek.com \
--cc=devicetree@vger.kernel.org \
--cc=geert+renesas@glider.be \
--cc=jic23@kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=lars@metafoo.de \
--cc=lgirdwood@gmail.com \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=okan.sahin@analog.com \
--cc=prabhakar.mahadev-lad.rj@bp.renesas.com \
--cc=ramona.bolboaca@analog.com \
--cc=robh+dt@kernel.org \
--cc=william.gray@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox