From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id D93DDC636D6 for ; Thu, 23 Feb 2023 16:53:54 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229489AbjBWQxx (ORCPT ); Thu, 23 Feb 2023 11:53:53 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50618 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229379AbjBWQxv (ORCPT ); Thu, 23 Feb 2023 11:53:51 -0500 Received: from galois.linutronix.de (Galois.linutronix.de [IPv6:2a0a:51c0:0:12e:550::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7261D4ECF2 for ; Thu, 23 Feb 2023 08:53:50 -0800 (PST) Date: Thu, 23 Feb 2023 17:53:45 +0100 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020; t=1677171228; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=PPkdGpOVZMRH9SM6Z7dqNvPo2gM32EX9HbvF5pyxx3w=; b=GmHFvbDOoUsuPuZRY2416+3hvxQMRBRgFu86d5fC0oAuGBua9OeS2CUQ4+rztacHWFGiyf qJyQtvspBl5I0WivIptl1VP1iI7K9FmPQsRnIWXpkl1CAul66gKAmSyc84p0T3Pywu8nvB cBMylkiqStr+4nySvwQGNTkPpMfIThdmv3S+nLBesVMLUOo4UGJ7Ra3jHo5Cwd2b+Xj8aj 6tUNylfnUXAYZLprNaaXorkQR5N5cZN2QIYkRgMroBiiJ7Rvsa2S6Z0kK9J9R3tzKi+Vlx QAMSaAkM3eDNgD2ROH6l+NUm9j/OArRtMzi54sQMEHQ1JEztAj+kFQOjskB7VA== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020e; t=1677171228; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=PPkdGpOVZMRH9SM6Z7dqNvPo2gM32EX9HbvF5pyxx3w=; b=rGRmlFS6xVN59xZgKx3KZM0lz188qes20hnMDPA/GkuEymtiOGMohnm0DdX7Y+eCaRYls2 WCYWPZir58UkmTCw== From: Sebastian Andrzej Siewior To: Peter Zijlstra Cc: linux-kernel@vger.kernel.org, Ben Segall , Daniel Bristot de Oliveira , Dietmar Eggemann , Ingo Molnar , Juri Lelli , Mel Gorman , Steven Rostedt , Thomas Gleixner , Valentin Schneider , Vincent Guittot Subject: Re: [PATCH] sched: Consider task_struct::saved_state in wait_task_inactive(). Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2023-02-22 14:36:14 [+0100], Peter Zijlstra wrote: > Which if the very few wait_task_inactive() users requires this? ptrace is the remaining (known) one (just verified on v6.2-rt3). ptrace_check_attach() waits for the child which blocks on tasklist_lock. tglx argued that wait_task_inactive() should work regardless of the task, that is being waited for, blocks on a sleeping lock. Sebastian