Re: [PATCH 2/2] mfd: tps65219: Add gpio cell instance

andy.shevchenko
2023-02-24T12:17:34Z

Fri, Feb 24, 2023 at 12:38:37PM +0100, Jerome Neanne kirjoitti:
> tps65219 PMIC GPIOs are exposed in a standard way:
> gpiodetect
> gpiochip0 [tps65219-gpio] (3 lines)
>
> Signed-off-by: Jonathan Cormier <jcormier@criticallink.com>
> Signed-off-by: Jerome Neanne <jneanne@baylibre.com>

Same issues with the commit message as per previous patch.

...

> @@ -267,6 +267,11 @@ static int tps65219_probe(struct i2c_client *client)
> return ret;
> }
>
> + if (ret) {
> + dev_err(tps->dev, "Failed to add gpio: %d\n", ret);
> + return ret;
> + }

Isn't it a dead code?

--
With Best Regards,
Andy Shevchenko