From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 34A38C64ED8 for ; Mon, 27 Feb 2023 12:53:46 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229636AbjB0Mxp (ORCPT ); Mon, 27 Feb 2023 07:53:45 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35476 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229684AbjB0Mxn (ORCPT ); Mon, 27 Feb 2023 07:53:43 -0500 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 05F4E59ED for ; Mon, 27 Feb 2023 04:53:42 -0800 (PST) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id E48D2C14; Mon, 27 Feb 2023 04:54:24 -0800 (PST) Received: from FVFF77S0Q05N (unknown [10.57.17.201]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id CE3D53F67D; Mon, 27 Feb 2023 04:53:40 -0800 (PST) Date: Mon, 27 Feb 2023 12:53:38 +0000 From: Mark Rutland To: Catalin Marinas Cc: kernel test robot , oe-kbuild-all@lists.linux.dev, linux-kernel@vger.kernel.org, "Rafael J. Wysocki" , Robert Moore Subject: Re: include/acpi/actypes.h:525:42: warning: 'strncpy' specified bound 4 equals destination size Message-ID: References: <202302230414.sQbDHtiC-lkp@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Feb 23, 2023 at 11:24:31AM +0000, Catalin Marinas wrote: > On Thu, Feb 23, 2023 at 04:32:41AM +0800, kernel test robot wrote: > > tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master > > head: 70756b49be4ea8bf36a664322df6e7e89895fa60 > > commit: 8f9e0a52810dd83406c768972d022c37e7a18f1f ACPI: Don't build ACPICA with '-Os' > > date: 4 weeks ago > > config: ia64-defconfig (https://download.01.org/0day-ci/archive/20230223/202302230414.sQbDHtiC-lkp@intel.com/config) > > compiler: ia64-linux-gcc (GCC) 12.1.0 > > reproduce (this is a W=1 build): > > wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross > > chmod +x ~/bin/make.cross > > # https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=8f9e0a52810dd83406c768972d022c37e7a18f1f > > git remote add linus https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git > > git fetch --no-tags linus master > > git checkout 8f9e0a52810dd83406c768972d022c37e7a18f1f > > # save the config file > > mkdir build_dir && cp config build_dir/.config > > COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=ia64 olddefconfig > > COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=ia64 SHELL=/bin/bash drivers/acpi/acpica/ > > > > If you fix the issue, kindly add following tag where applicable > > | Reported-by: kernel test robot > > | Link: https://lore.kernel.org/oe-kbuild-all/202302230414.sQbDHtiC-lkp@intel.com/ > > > > All warnings (new ones prefixed by >>): > > > > In file included from include/acpi/acpi.h:24, > > from drivers/acpi/acpica/tbfind.c:10: > > drivers/acpi/acpica/tbfind.c: In function 'acpi_tb_find_table': > > >> include/acpi/actypes.h:525:42: warning: 'strncpy' specified bound 4 equals destination size [-Wstringop-truncation] > > 525 | #define ACPI_COPY_NAMESEG(dest,src) (strncpy (ACPI_CAST_PTR (char, (dest)), ACPI_CAST_PTR (char, (src)), ACPI_NAMESEG_SIZE)) > > | ~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > > I don't see how this is related to the reported commit (which only > removed the -Os option for gcc). I looks like `-Os` disables the warning for some reason. I suspect that's down to compiler passes not propagating the constants when using `-Os`. The actual issue has nothing to do with this patch; this patch just happens to have unearthed it. > I think ACPI_COPY_NAMESEG() should just use memcpy() on ia64 but this > strncpy() has been around for over 10 years. Agreed. IIUC ia64 is likely to disappear soon, so maybe we don't need to touch this... Thanks, Mark.