From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: William Breathitt Gray <william.gray@linaro.org>
Cc: linus.walleij@linaro.org, brgl@bgdev.pl, broonie@kernel.org,
linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 5/6] gpio: pci-idio-16: Migrate to the regmap API
Date: Fri, 17 Feb 2023 21:07:19 +0200 [thread overview]
Message-ID: <Y+/QZ7VX2EAxweIt@smile.fi.intel.com> (raw)
In-Reply-To: <Y+/PwYe3pvtausbe@smile.fi.intel.com>
On Fri, Feb 17, 2023 at 09:04:33PM +0200, Andy Shevchenko wrote:
> On Wed, Feb 08, 2023 at 12:18:20PM -0500, William Breathitt Gray wrote:
> > The regmap API supports MMIO accessors so we can take advantage of
> > regmap abstractions rather than handling access to the device registers
> > directly in the driver. Migrate the pci-idio-16 module to the new
> > idio-16 library interface leveraging the gpio-regmap API.
>
> Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
>
> Don't you need to allow PIO accessors in the regmap configuration?
If not, update a commit message accordingly.
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2023-02-17 19:07 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-08 17:18 [PATCH 0/6] Migrate IDIO-16 GPIO drivers to regmap API William Breathitt Gray
2023-02-08 17:18 ` [PATCH 1/6] regmap-irq: Add no_status support William Breathitt Gray
2023-02-17 18:57 ` Andy Shevchenko
2023-02-08 17:18 ` [PATCH 2/6] gpio: 104-dio-48e: Utilize no_status regmap-irq flag William Breathitt Gray
2023-02-17 18:58 ` Andy Shevchenko
2023-02-08 17:18 ` [PATCH 3/6] gpio: idio-16: Migrate to the regmap API William Breathitt Gray
2023-02-17 19:00 ` Andy Shevchenko
2023-02-08 17:18 ` [PATCH 4/6] gpio: 104-idio-16: " William Breathitt Gray
2023-02-17 19:01 ` Andy Shevchenko
2023-02-17 21:08 ` William Breathitt Gray
2023-02-08 17:18 ` [PATCH 5/6] gpio: pci-idio-16: " William Breathitt Gray
2023-02-17 19:04 ` Andy Shevchenko
2023-02-17 19:07 ` Andy Shevchenko [this message]
2023-02-08 17:18 ` [PATCH 6/6] gpio: idio-16: Remove unused legacy interface William Breathitt Gray
2023-02-17 19:06 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y+/QZ7VX2EAxweIt@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=brgl@bgdev.pl \
--cc=broonie@kernel.org \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=william.gray@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox