From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on
	aws-us-west-2-korg-lkml-1.web.codeaurora.org
Received: from vger.kernel.org (vger.kernel.org [23.128.96.18])
	by smtp.lore.kernel.org (Postfix) with ESMTP id C12EFC64EC4
	for <linux-kernel@archiver.kernel.org>; Fri, 17 Feb 2023 15:36:17 +0000 (UTC)
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S230344AbjBQPgQ (ORCPT <rfc822;linux-kernel@archiver.kernel.org>);
        Fri, 17 Feb 2023 10:36:16 -0500
Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35314 "EHLO
        lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S229539AbjBQPgO (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Fri, 17 Feb 2023 10:36:14 -0500
Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217])
        by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6372F6F3CE;
        Fri, 17 Feb 2023 07:36:12 -0800 (PST)
Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140])
        (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
        (No client certificate requested)
        by dfw.source.kernel.org (Postfix) with ESMTPS id F227C61DF0;
        Fri, 17 Feb 2023 15:36:11 +0000 (UTC)
Received: by smtp.kernel.org (Postfix) with ESMTPSA id 15151C433D2;
        Fri, 17 Feb 2023 15:36:10 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org;
        s=korg; t=1676648171;
        bh=k+ucdwVw1hglqULunr645HzuKVDKGPu0NV5mX/S91AU=;
        h=Date:From:To:Cc:Subject:References:In-Reply-To:From;
        b=IOp4WNS6TyWeUQaCmXucGZJmxwcR0X7o8k7wYcl7TJpXxgmD7aSUhxu13t23vxgnD
         hrHxYef8jWF1+P5TYCeFyBq86mARUMf5h+B3jEQ2a9sscfjAx3vnjamFlvbggkZlOO
         gLQSr4/yfps5H9La1FfXR6QSXn3KNgX5pNkxExx4=
Date:   Fri, 17 Feb 2023 16:36:08 +0100
From:   Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To:     Angelo Compagnucci <angelo.compagnucci@gmail.com>
Cc:     Derek Kiernan <derek.kiernan@xilinx.com>,
        Dragan Cvetic <dragan.cvetic@xilinx.com>,
        Arnd Bergmann <arnd@arndb.de>,
        Angelo Compagnucci <angelo@amarulasolutions.com>,
        Thierry Reding <thierry.reding@gmail.com>,
        Uwe =?iso-8859-1?Q?Kleine-K=F6nig?= 
        <u.kleine-koenig@pengutronix.de>, linux-kernel@vger.kernel.org,
        linux-pwm@vger.kernel.org
Subject: Re: [PATCH v2 1/3] misc: servo-pwm: driver for controlling servo
 motors via PWM
Message-ID: <Y++e6IMusukWJNw2@kroah.com>
References: <20230217145731.3018148-1-angelo@amarulasolutions.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20230217145731.3018148-1-angelo@amarulasolutions.com>
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Fri, Feb 17, 2023 at 03:57:28PM +0100, Angelo Compagnucci wrote:
> This patch adds a simple driver to control servo motor position via
> PWM signal.
> The driver allows to set the angle from userspace, while min/max
> positions duty cycle and the motor degrees aperture are defined in
> the dts.
> 
> Signed-off-by: Angelo Compagnucci <angelo@amarulasolutions.com>
> ---
>  MAINTAINERS              |   6 ++
>  drivers/misc/Kconfig     |  11 +++
>  drivers/misc/Makefile    |   1 +
>  drivers/misc/servo-pwm.c | 149 +++++++++++++++++++++++++++++++++++++++

You add sysfs files but do not document them in Documentation/ABI/ which
is required.  Please do so in your next version of this patch.

> +static ssize_t degrees_show(struct device *dev, struct device_attribute *attr,
> +			  char *buf)
> +{
> +	struct servo_pwm_data *data = dev_get_drvdata(dev);
> +
> +	return snprintf(buf, PAGE_SIZE, "%u\n", data->degrees);

sysfs_emit() please.

thanks,

greg k-h