From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 30B5EC05027 for ; Fri, 17 Feb 2023 15:48:32 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230380AbjBQPsa (ORCPT ); Fri, 17 Feb 2023 10:48:30 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45430 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229772AbjBQPs2 (ORCPT ); Fri, 17 Feb 2023 10:48:28 -0500 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 119416242B; Fri, 17 Feb 2023 07:48:23 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id A08CB61C41; Fri, 17 Feb 2023 15:48:22 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id A2D12C433EF; Fri, 17 Feb 2023 15:48:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1676648902; bh=PiaP3F/e2OCvqSO0RZPWsvSFE4YpRMF5iNcvchHbYt4=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=ig4EOfqo+2A/r0I4abeOkS7p9W4F7iqioRJ5HfPZc/m4DkkvmQADwkeMoN0UiuUQ+ SQr60sf+4h9nTcRnbLLktVzbvFcPmPNrQFVcyByU80xno9riXj8Z9V9Hj53j8c72OH qbuD/ERPh2ZV0HRxAPm8TU/KhS8JMFq7gIew11wI= Date: Fri, 17 Feb 2023 16:48:19 +0100 From: Greg Kroah-Hartman To: Angelo Compagnucci Cc: Angelo Compagnucci , Derek Kiernan , Dragan Cvetic , Arnd Bergmann , Thierry Reding , Uwe =?iso-8859-1?Q?Kleine-K=F6nig?= , linux-kernel@vger.kernel.org, linux-pwm@vger.kernel.org Subject: Re: [PATCH v2 1/3] misc: servo-pwm: driver for controlling servo motors via PWM Message-ID: References: <20230217145731.3018148-1-angelo@amarulasolutions.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Feb 17, 2023 at 04:39:01PM +0100, Angelo Compagnucci wrote: > On Fri, Feb 17, 2023 at 4:36 PM Greg Kroah-Hartman < > gregkh@linuxfoundation.org> wrote: > > > On Fri, Feb 17, 2023 at 03:57:28PM +0100, Angelo Compagnucci wrote: > > > This patch adds a simple driver to control servo motor position via > > > PWM signal. > > > The driver allows to set the angle from userspace, while min/max > > > positions duty cycle and the motor degrees aperture are defined in > > > the dts. > > > > > > Signed-off-by: Angelo Compagnucci > > > --- > > > MAINTAINERS | 6 ++ > > > drivers/misc/Kconfig | 11 +++ > > > drivers/misc/Makefile | 1 + > > > drivers/misc/servo-pwm.c | 149 +++++++++++++++++++++++++++++++++++++++ > > > > You add sysfs files but do not document them in Documentation/ABI/ which > > is required. Please do so in your next version of this patch. > > > > https://patchwork.ozlabs.org/project/linux-pwm/patch/20230217145731.3018148-2-angelo@amarulasolutions.com/ > > This patch [2/3] should do what you're asking. Why was I only cc:ed on this one patch? confused, greg k-h