Re: [PATCH v14 08/17] splice: Do splice read from a file without using ITER_PIPE

Alexander Egorenkov
2023-02-17T20:39:42Z

Hello,

this commit breaks our s390x tests on linux-next which use Python 3
among other things.

We are using the Python 3 tox module and for some reason,
the above commit makes Python create files with padded zeroes.

--- a/tox/distro/lib/python3.11/site-packages/_distutils_hack/__init__.py
+++ b/tox/distro/lib/python3.11/site-packages/_distutils_hack/__init__.py
@@ -381,133 +381,4 @@
000017c0 49 4c 53 5f 46 49 4e 44 45 52 29 0a 20 20 20 20 |ILS_FINDER). |
000017d0 65 78 63 65 70 74 20 56 61 6c 75 65 45 72 72 6f |except ValueErro|
000017e0 72 3a 0a 20 20 20 20 20 20 20 20 70 61 73 73 0a |r:. pass.|
-000017f0 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 |................|
-00001800 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 |................|
-00001810 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 |................|
-00001820 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 |................|
-00001830 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 |................|
-00001840 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 |................|
-00001850 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 |................|
-00001860 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 |................|
...

How to reproduce on Fedora
--------------------------

# dnf install -y python3-tox

# cat >tox.ini <<EOF
[tox]
envlist = dev,distro,doc,lint
skipsdist = True

[testenv:distro]
sitepackages = true
EOF

# python3 -m tox -v --notest -e distro

Error processing line 1 of /mnt/test/.tox/distro/lib/python3.11/site-packages/distutils-precedence.pth:

Traceback (most recent call last):
File "<frozen site>", line 186, in addpackage
File "<string>", line 1, in <module>
ValueError: source code string cannot contain null bytes

Remainder of file ignored

# The above error message disappears if one reverts the bad commit.

Regards
Alex