Re: [PATCH v14 05/17] overlayfs: Implement splice-read

David Howells
2023-02-15T15:04:54Z

Miklos Szeredi <miklos@szeredi.hu> wrote:

> > + ret = -EINVAL;
> > + if (in->f_flags & O_DIRECT &&
> > + !(real.file->f_mode & FMODE_CAN_ODIRECT))
> > + goto out_fdput;
>
> This is unnecessary, as it was already done in ovl_real_fdget() ->
> ovl_real_fdget_meta() -> ovl_change_flags().

Does that mean ovl_read_iter() and ovl_write_iter() shouldn't be doing it,
then?

David