Re: [PATCH v14 05/17] overlayfs: Implement splice-read

Miklos Szeredi
2023-02-15T15:32:50Z

On Wed, 15 Feb 2023 at 16:04, David Howells <dhowells@redhat.com> wrote:
>
> Miklos Szeredi <miklos@szeredi.hu> wrote:
>
> > > + ret = -EINVAL;
> > > + if (in->f_flags & O_DIRECT &&
> > > + !(real.file->f_mode & FMODE_CAN_ODIRECT))
> > > + goto out_fdput;
> >
> > This is unnecessary, as it was already done in ovl_real_fdget() ->
> > ovl_real_fdget_meta() -> ovl_change_flags().
>
> Does that mean ovl_read_iter() and ovl_write_iter() shouldn't be doing it,
> then?

That's a different thing, because ovl_*_iter() are checking on
ki->flags, not f_flags.

Thanks,
Miklos