From: Ming Lei <ming.lei@redhat.com>
To: Jinke Han <hanjinke.666@bytedance.com>
Cc: axboe@kernel.dk, linux-block@vger.kernel.org,
linux-kernel@vger.kernel.org, muchun.song@linux.dev
Subject: Re: [PATCH] block: Fix io statistics for cgroup in throttle path
Date: Thu, 16 Feb 2023 14:33:06 +0800 [thread overview]
Message-ID: <Y+3OInqy6EaeUfF8@T590> (raw)
In-Reply-To: <20230216032250.74230-1-hanjinke.666@bytedance.com>
On Thu, Feb 16, 2023 at 11:22:50AM +0800, Jinke Han wrote:
> From: Jinke Han <hanjinke.666@bytedance.com>
>
> In the current code, io statistics are missing for cgroup when bio
> was throttled by blk-throttle. Fix it by moving the unreaching code
> to submit_bio_noacct_nocheck.
>
> Fixes: 3f98c753717c ("block: don't check bio in blk_throtl_dispatch_work_fn")
> Signed-off-by: Jinke Han <hanjinke.666@bytedance.com>
Looks fine,
Reviewed-by: Ming Lei <ming.lei@redhat.com>
Thanks,
Ming
next prev parent reply other threads:[~2023-02-16 6:34 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-16 3:22 [PATCH] block: Fix io statistics for cgroup in throttle path Jinke Han
2023-02-16 6:08 ` Christoph Hellwig
2023-02-16 6:33 ` Ming Lei [this message]
2023-02-16 6:57 ` Muchun Song
2023-02-16 18:05 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y+3OInqy6EaeUfF8@T590 \
--to=ming.lei@redhat.com \
--cc=axboe@kernel.dk \
--cc=hanjinke.666@bytedance.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=muchun.song@linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox