From: Andrew Lunn <andrew@lunn.ch>
To: Oleksij Rempel <o.rempel@pengutronix.de>
Cc: Larysa Zaremba <larysa.zaremba@intel.com>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Wei Fang <wei.fang@nxp.com>,
Heiner Kallweit <hkallweit1@gmail.com>,
kernel@pengutronix.de, linux-kernel@vger.kernel.org,
netdev@vger.kernel.org, Shenwei Wang <shenwei.wang@nxp.com>,
Clark Wang <xiaoning.wang@nxp.com>,
NXP Linux Team <linux-imx@nxp.com>
Subject: Re: [PATCH net-next v1 7/7] net: fec: add support for PHYs with SmartEEE support
Date: Thu, 16 Feb 2023 13:49:47 +0100 [thread overview]
Message-ID: <Y+4ma61Gf3G3D6Bh@lunn.ch> (raw)
In-Reply-To: <20230216091142.GA1974@pengutronix.de>
> I would prefer to not touch phy_init_eee(). At least not in this patch
> set. With this function we have following situation:
We have a complete mess :-(
I spent yesterday re-writing the MAC driver side of EEE. Most get it
completely wrong, as you point out. So i changed the API a bit, making
it more like other negotiated things, so i hope developers will get it
correct in the future. I will post an RFC/RFT series soon.
> Hm.. I need to admit, EEE should not be advertised by default. Only
> if MAC driver calls something like phy_support_eee(), we should start doing it.
This i've not looked at yet. But i agree.
Andrew
prev parent reply other threads:[~2023-02-16 12:50 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-14 9:03 [PATCH net-next v1 0/7] make SmartEEE support controllable Oleksij Rempel
2023-02-14 9:03 ` [PATCH net-next v1 1/7] net: phy: add driver specific get/set_eee support Oleksij Rempel
2023-02-14 9:03 ` [PATCH net-next v1 2/7] net: phy: at803x: implement ethtool access to SmartEEE functionality Oleksij Rempel
2023-02-14 9:03 ` [PATCH net-next v1 3/7] net: phy: at803x: ar8035: fix EEE support for half duplex links Oleksij Rempel
2023-02-14 9:03 ` [PATCH net-next v1 4/7] net: phy: add PHY specifica flag to signal SmartEEE support Oleksij Rempel
2023-02-14 9:03 ` [PATCH net-next v1 5/7] net: phy: at803x: add PHY_SMART_EEE flag to AR8035 Oleksij Rempel
2023-02-14 9:03 ` [PATCH net-next v1 6/7] net: phy: add phy_has_smarteee() helper Oleksij Rempel
2023-02-14 9:03 ` [PATCH net-next v1 7/7] net: fec: add support for PHYs with SmartEEE support Oleksij Rempel
2023-02-14 13:26 ` Andrew Lunn
2023-02-15 14:14 ` Larysa Zaremba
2023-02-16 9:11 ` Oleksij Rempel
2023-02-16 12:49 ` Andrew Lunn [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y+4ma61Gf3G3D6Bh@lunn.ch \
--to=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=hkallweit1@gmail.com \
--cc=kernel@pengutronix.de \
--cc=kuba@kernel.org \
--cc=larysa.zaremba@intel.com \
--cc=linux-imx@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=o.rempel@pengutronix.de \
--cc=pabeni@redhat.com \
--cc=shenwei.wang@nxp.com \
--cc=wei.fang@nxp.com \
--cc=xiaoning.wang@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox