From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id CCD1FC636D4 for ; Mon, 6 Feb 2023 19:49:32 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230105AbjBFTtb (ORCPT ); Mon, 6 Feb 2023 14:49:31 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37174 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229500AbjBFTt3 (ORCPT ); Mon, 6 Feb 2023 14:49:29 -0500 Received: from out-134.mta0.migadu.com (out-134.mta0.migadu.com [IPv6:2001:41d0:1004:224b::86]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8A56424484 for ; Mon, 6 Feb 2023 11:49:28 -0800 (PST) Date: Mon, 6 Feb 2023 19:49:18 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1675712965; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=eE5y7KFp1wd1MeVmYVGZn0fpjFrmo4GGrmTq6cDBY5c=; b=vKcW3ipuJCGN+k+eCjH0TntuFx6caxzWhEiSfSpZXXLGTvchIZpN7/REJp+2QmHkW6djhs oJv4nlwVpdaL6mlTmn4TJHA+IxFygHc1muN+oCrG5yERThMZOuRztClFBU+h7t2fwguyfI 0tAxULUD9yv8rC8Xnewf9lqgPaWV/O0= X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Oliver Upton To: Sean Christopherson Cc: Mark Brown , Paolo Bonzini , Shuah Khan , kvm@vger.kernel.org, linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org, anup@brainfault.org Subject: Re: [PATCH] KVM: selftests: Enable USERFAULTFD Message-ID: References: <20230202-kvm-selftest-userfaultfd-v1-1-8186ac5a33a5@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Migadu-Flow: FLOW_OUT Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Feb 06, 2023 at 06:15:16PM +0000, Sean Christopherson wrote: > On Mon, Feb 06, 2023, Oliver Upton wrote: > > +cc x86, riscv as they're also affected. > > > > On Thu, Feb 02, 2023 at 09:01:36PM +0000, Mark Brown wrote: > > > The page_fault_test KVM selftest requires userfaultfd but the config > > > fragment for the KVM selftests does not enable it, meaning that those tests > > > are skipped in CI systems that rely on appropriate settings in the config > > > fragments except on S/390 which happens to have it in defconfig. Enable > > > the option in the config fragment so that the tests get run. > > What do CI systems do for HugeTLB and THP? Those are the other config options I > can think of where there are very interesting interactions from a KVM perspective, > but where KVM doesn't have a strict dependency on the feature. > > E.g. x86_64_defconfig selects CONFIG_HUGETLBFS=y, but I don't see anything for THP, > and AFAICT TRANSPARENT_HUGEPAGE is default=n. Looks like arm64 defconfig enables THP and hugetlb. Regardless, I think it would be valuable if our Kconfig fragment expressed the options that buy us additional code coverage. -- Thanks, Oliver