From: Andrew Lunn <andrew@lunn.ch>
To: Oleksij Rempel <o.rempel@pengutronix.de>
Cc: Woojung Huh <woojung.huh@microchip.com>,
UNGLinuxDriver@microchip.com,
Vivien Didelot <vivien.didelot@gmail.com>,
Florian Fainelli <f.fainelli@gmail.com>,
Vladimir Oltean <olteanv@gmail.com>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Wei Fang <wei.fang@nxp.com>,
Heiner Kallweit <hkallweit1@gmail.com>,
kernel@pengutronix.de, linux-kernel@vger.kernel.org,
netdev@vger.kernel.org, Arun.Ramadoss@microchip.com,
intel-wired-lan@lists.osuosl.org
Subject: Re: [PATCH net-next v5 08/23] net: phy: migrate phy_init_eee() to genphy_c45_eee_is_active()
Date: Tue, 7 Feb 2023 01:54:36 +0100 [thread overview]
Message-ID: <Y+GhTEpwx+jP8S09@lunn.ch> (raw)
In-Reply-To: <20230206135050.3237952-9-o.rempel@pengutronix.de>
On Mon, Feb 06, 2023 at 02:50:35PM +0100, Oleksij Rempel wrote:
> Reduce code duplicated by migrating phy_init_eee() to
> genphy_c45_eee_is_active().
>
> Signed-off-by: Oleksij Rempel <o.rempel@pengutronix.de>
This makes sense, but as i said in a different thread, i think the
MAC/PHY API needs improving at some point, which could result in this
function going away. But this patchset is big enough as it is.
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Andrew
next prev parent reply other threads:[~2023-02-07 0:54 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-06 13:50 [PATCH net-next v5 00/23] net: add EEE support for KSZ9477 and AR8035 with i.MX6 Oleksij Rempel
2023-02-06 13:50 ` [PATCH net-next v5 01/23] net: dsa: microchip: enable EEE support Oleksij Rempel
2023-02-07 0:44 ` Andrew Lunn
2023-02-06 13:50 ` [PATCH net-next v5 02/23] net: phy: add genphy_c45_read_eee_abilities() function Oleksij Rempel
2023-02-06 14:46 ` Arun.Ramadoss
2023-02-07 0:44 ` Andrew Lunn
2023-02-08 5:19 ` Jakub Kicinski
2023-02-06 13:50 ` [PATCH net-next v5 03/23] net: phy: micrel: add ksz9477_get_features() Oleksij Rempel
2023-02-07 0:45 ` Andrew Lunn
2023-02-06 13:50 ` [PATCH net-next v5 04/23] net: phy: export phy_check_valid() function Oleksij Rempel
2023-02-06 13:50 ` [PATCH net-next v5 05/23] net: phy: add genphy_c45_ethtool_get/set_eee() support Oleksij Rempel
2023-02-06 14:54 ` Arun.Ramadoss
2023-02-06 13:50 ` [PATCH net-next v5 06/23] net: phy: c22: migrate to genphy_c45_write_eee_adv() Oleksij Rempel
2023-02-07 0:52 ` Andrew Lunn
2023-02-06 13:50 ` [PATCH net-next v5 07/23] net: phy: c45: " Oleksij Rempel
2023-02-07 0:52 ` Andrew Lunn
2023-02-06 13:50 ` [PATCH net-next v5 08/23] net: phy: migrate phy_init_eee() to genphy_c45_eee_is_active() Oleksij Rempel
2023-02-07 0:54 ` Andrew Lunn [this message]
2023-02-06 13:50 ` [PATCH net-next v5 09/23] net: phy: start using genphy_c45_ethtool_get/set_eee() Oleksij Rempel
2023-02-07 1:05 ` Andrew Lunn
2023-02-06 13:50 ` [PATCH net-next v5 10/23] net: phy: add driver specific get/set_eee support Oleksij Rempel
2023-02-06 13:50 ` [PATCH net-next v5 11/23] net: phy: at803x: implement ethtool access to SmartEEE functionality Oleksij Rempel
2023-02-06 13:50 ` [PATCH net-next v5 12/23] net: phy: at803x: ar8035: fix EEE support for half duplex links Oleksij Rempel
2023-02-06 13:50 ` [PATCH net-next v5 13/23] net: phy: add PHY specifica flag to signal SmartEEE support Oleksij Rempel
2023-02-06 13:50 ` [PATCH net-next v5 14/23] net: phy: at803x: add PHY_SMART_EEE flag to AR8035 Oleksij Rempel
2023-02-06 13:50 ` [PATCH net-next v5 15/23] net: phy: add phy_has_smarteee() helper Oleksij Rempel
2023-02-08 5:20 ` Jakub Kicinski
2023-02-06 13:50 ` [PATCH net-next v5 16/23] net: fec: add support for PHYs with SmartEEE support Oleksij Rempel
2023-02-06 13:50 ` [PATCH net-next v5 17/23] e1000e: replace EEE ethtool helpers to linkmode variants Oleksij Rempel
2023-02-06 13:50 ` [PATCH net-next v5 18/23] igb: " Oleksij Rempel
2023-02-06 13:50 ` [PATCH net-next v5 19/23] igc: " Oleksij Rempel
2023-02-06 13:50 ` [PATCH net-next v5 20/23] tg3: " Oleksij Rempel
2023-02-06 13:50 ` [PATCH net-next v5 21/23] r8152: " Oleksij Rempel
2023-02-06 13:50 ` [PATCH net-next v5 22/23] net: usb: ax88179_178a: " Oleksij Rempel
2023-02-06 13:50 ` [PATCH net-next v5 23/23] net: mdio: drop EEE ethtool helpers in favor " Oleksij Rempel
2023-02-08 5:25 ` [PATCH net-next v5 00/23] net: add EEE support for KSZ9477 and AR8035 with i.MX6 Jakub Kicinski
2023-02-08 8:30 ` Oleksij Rempel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y+GhTEpwx+jP8S09@lunn.ch \
--to=andrew@lunn.ch \
--cc=Arun.Ramadoss@microchip.com \
--cc=UNGLinuxDriver@microchip.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=f.fainelli@gmail.com \
--cc=hkallweit1@gmail.com \
--cc=intel-wired-lan@lists.osuosl.org \
--cc=kernel@pengutronix.de \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=o.rempel@pengutronix.de \
--cc=olteanv@gmail.com \
--cc=pabeni@redhat.com \
--cc=vivien.didelot@gmail.com \
--cc=wei.fang@nxp.com \
--cc=woojung.huh@microchip.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox