From: Greg KH <gregkh@linuxfoundation.org>
To: Elson Roy Serrao <quic_eserrao@quicinc.com>
Cc: Thinh.Nguyen@synopsys.com, balbi@kernel.org,
linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org,
quic_wcheng@quicinc.com, quic_jackp@quicinc.com
Subject: Re: [PATCH v3 3/5] usb: gadget: Add function wakeup support
Date: Tue, 7 Feb 2023 06:56:20 +0100 [thread overview]
Message-ID: <Y+HoBPM6a64erF3z@kroah.com> (raw)
In-Reply-To: <1675710806-9735-4-git-send-email-quic_eserrao@quicinc.com>
On Mon, Feb 06, 2023 at 11:13:24AM -0800, Elson Roy Serrao wrote:
> A function which is in function suspend state has to send a
> function wake notification to the host in case it needs to
> exit from this state and resume data transfer. Add support to
> handle such requests by exposing a new gadget op.
>
> Signed-off-by: Elson Roy Serrao <quic_eserrao@quicinc.com>
> ---
> drivers/usb/gadget/composite.c | 26 ++++++++++++++++++++++++++
> drivers/usb/gadget/udc/core.c | 19 +++++++++++++++++++
> include/linux/usb/composite.h | 6 ++++++
> include/linux/usb/gadget.h | 4 ++++
> 4 files changed, 55 insertions(+)
>
> diff --git a/drivers/usb/gadget/composite.c b/drivers/usb/gadget/composite.c
> index e459fb0..aa243d8 100644
> --- a/drivers/usb/gadget/composite.c
> +++ b/drivers/usb/gadget/composite.c
> @@ -492,6 +492,32 @@ int usb_interface_id(struct usb_configuration *config,
> }
> EXPORT_SYMBOL_GPL(usb_interface_id);
>
> +int usb_func_wakeup(struct usb_function *func)
> +{
> + int ret, id;
> +
> + if (!func->func_rw_armed) {
> + ERROR(func->config->cdev, "func remote wakeup not enabled\n");
> + return -EINVAL;
> + }
> +
> + DBG(func->config->cdev, "%s function wakeup\n", func->name);
> +
> + for (id = 0; id < MAX_CONFIG_INTERFACES; id++)
> + if (func->config->interface[id] == func)
> + break;
> +
> + if (id == MAX_CONFIG_INTERFACES) {
> + ERROR(func->config->cdev, "Invalid function id:%d\n", id);
> + return -EINVAL;
> + }
> +
> + ret = usb_gadget_func_wakeup(func->config->cdev->gadget, id);
> +
> + return ret;
> +}
> +EXPORT_SYMBOL(usb_func_wakeup);
EXPORT_SYMBOL_GPL() please.
thanks,
greg k-h
next prev parent reply other threads:[~2023-02-07 5:56 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-06 19:13 [PATCH v3 0/5] Add function suspend/resume and remote wakeup support Elson Roy Serrao
2023-02-06 19:13 ` [PATCH v3 1/5] usb: gadget: Properly configure the device for remote wakeup Elson Roy Serrao
2023-02-06 20:14 ` Alan Stern
2023-02-06 20:30 ` Elson Serrao
2023-02-07 0:24 ` Thinh Nguyen
2023-02-06 19:13 ` [PATCH v3 2/5] usb: dwc3: Add remote wakeup handling Elson Roy Serrao
2023-02-07 0:48 ` Thinh Nguyen
2023-02-07 22:41 ` Elson Serrao
2023-02-08 1:10 ` Thinh Nguyen
2023-02-08 1:51 ` Elson Serrao
2023-02-08 2:11 ` Thinh Nguyen
2023-02-10 1:36 ` Elson Serrao
2023-02-10 2:27 ` Thinh Nguyen
2023-02-10 3:43 ` Elson Serrao
2023-02-07 10:45 ` kernel test robot
2023-02-06 19:13 ` [PATCH v3 3/5] usb: gadget: Add function wakeup support Elson Roy Serrao
2023-02-07 1:14 ` Thinh Nguyen
2023-02-07 5:56 ` Greg KH [this message]
2023-02-06 19:13 ` [PATCH v3 4/5] usb: dwc3: Add function suspend and " Elson Roy Serrao
2023-02-06 19:13 ` [PATCH v3 5/5] usb: gadget: f_ecm: Add suspend/resume and remote " Elson Roy Serrao
2023-02-07 1:24 ` [PATCH v3 0/5] Add function " Thinh Nguyen
2023-02-07 2:14 ` Elson Serrao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y+HoBPM6a64erF3z@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=Thinh.Nguyen@synopsys.com \
--cc=balbi@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=quic_eserrao@quicinc.com \
--cc=quic_jackp@quicinc.com \
--cc=quic_wcheng@quicinc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox