public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Ming Lei <ming.lei@redhat.com>
To: Ziyang Zhang <ZiyangZhang@linux.alibaba.com>
Cc: axboe@kernel.dk, linux-block@vger.kernel.org,
	linux-kernel@vger.kernel.org, joseph.qi@linux.alibaba.com
Subject: Re: [PATCH RESEND 2/3] ublk: mention WRITE_ZEROES in comment of ublk_complete_rq()
Date: Tue, 7 Feb 2023 22:07:38 +0800	[thread overview]
Message-ID: <Y+JbKrbExeQ7uIvC@T590> (raw)
In-Reply-To: <20230207070839.370817-3-ZiyangZhang@linux.alibaba.com>

On Tue, Feb 07, 2023 at 03:08:38PM +0800, Ziyang Zhang wrote:
> WRITE_ZEROES won't return bytes returned just like FLUSH and DISCARD,
> and we can end it directly. Add missing comment for it in
> ublk_complete_rq().
> 
> Signed-off-by: Ziyang Zhang <ZiyangZhang@linux.alibaba.com>
> ---
>  drivers/block/ublk_drv.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/block/ublk_drv.c b/drivers/block/ublk_drv.c
> index 55fccce68a9c..06eddefdf02a 100644
> --- a/drivers/block/ublk_drv.c
> +++ b/drivers/block/ublk_drv.c
> @@ -665,7 +665,7 @@ static void ublk_complete_rq(struct request *req)
>  	}
>  
>  	/*
> -	 * FLUSH or DISCARD usually won't return bytes returned, so end them
> +	 * FLUSH, DISCARD or WRITE_ZEROES usually won't return bytes returned, so end them
>  	 * directly.
>  	 *
>  	 * Both the two needn't unmap.

Reviewed-by: Ming Lei <ming.lei@redhat.com>


Thanks, 
Ming


  reply	other threads:[~2023-02-07 14:08 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-02-07  7:08 [PATCH RESEND 0/3] cleanup for ublk Ziyang Zhang
2023-02-07  7:08 ` [PATCH RESEND 1/3] ublk: remove unnecessary NULL check in ublk_rq_has_data() Ziyang Zhang
2023-02-07 14:06   ` Ming Lei
2023-02-07  7:08 ` [PATCH RESEND 2/3] ublk: mention WRITE_ZEROES in comment of ublk_complete_rq() Ziyang Zhang
2023-02-07 14:07   ` Ming Lei [this message]
2023-02-07  7:08 ` [PATCH RESEND 3/3] ublk: pass NULL to blk_mq_alloc_disk() as queuedata Ziyang Zhang
2023-02-07 14:08   ` Ming Lei
2023-02-07 14:21 ` [PATCH RESEND 0/3] cleanup for ublk Jens Axboe

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Y+JbKrbExeQ7uIvC@T590 \
    --to=ming.lei@redhat.com \
    --cc=ZiyangZhang@linux.alibaba.com \
    --cc=axboe@kernel.dk \
    --cc=joseph.qi@linux.alibaba.com \
    --cc=linux-block@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox