From: Jack Rosenthal <jrosenth@chromium.org>
To: Douglas Anderson <dianders@chromium.org>
Cc: Benson Leung <bleung@chromium.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Julius Werner <jwerner@chromium.org>,
David Gow <davidgow@google.com>,
chrome-platform@lists.linux.dev,
Stephen Boyd <swboyd@chromium.org>,
Guenter Roeck <groeck@chromium.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] firmware: coreboot: Remove GOOGLE_COREBOOT_TABLE_ACPI/OF Kconfig entries
Date: Tue, 7 Feb 2023 11:02:52 -0700 [thread overview]
Message-ID: <Y+KSTG92TtFK4PQm@chromium.org> (raw)
In-Reply-To: <20230207081130.1.I657776750156793721efa247ce6293445137bc8a@changeid>
On 2023-02-07 at 08:12 -0800, Douglas Anderson wrote:
> Ever since commit a28aad66da8b ("firmware: coreboot: Collapse platform
> drivers into bus core") the Kconfig entries GOOGLE_COREBOOT_TABLE_OF
> and GOOGLE_COREBOOT_TABLE_ACPI have been dead. They have no "help"
> text and thus aren't user choosable. They also aren't "select"ed by
> anything. They also control the compilation of no code.
>
> Let's remove them.
>
> Fixes: a28aad66da8b ("firmware: coreboot: Collapse platform drivers into bus core")
> Signed-off-by: Douglas Anderson <dianders@chromium.org>
Reviewed-by: Jack Rosenthal <jrosenth@chromium.org>
> ---
>
> drivers/firmware/google/Kconfig | 8 --------
> 1 file changed, 8 deletions(-)
>
> diff --git a/drivers/firmware/google/Kconfig b/drivers/firmware/google/Kconfig
> index 9f190eab43ed..1bc7cbf2f65d 100644
> --- a/drivers/firmware/google/Kconfig
> +++ b/drivers/firmware/google/Kconfig
> @@ -44,14 +44,6 @@ config GOOGLE_COREBOOT_TABLE
> device tree node /firmware/coreboot.
> If unsure say N.
>
> -config GOOGLE_COREBOOT_TABLE_ACPI
> - tristate
> - select GOOGLE_COREBOOT_TABLE
> -
> -config GOOGLE_COREBOOT_TABLE_OF
> - tristate
> - select GOOGLE_COREBOOT_TABLE
> -
> config GOOGLE_MEMCONSOLE
> tristate
> depends on GOOGLE_MEMCONSOLE_X86_LEGACY || GOOGLE_MEMCONSOLE_COREBOOT
> --
> 2.39.1.519.gcb327c4b5f-goog
>
next prev parent reply other threads:[~2023-02-07 18:03 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-07 16:12 [PATCH] firmware: coreboot: Remove GOOGLE_COREBOOT_TABLE_ACPI/OF Kconfig entries Douglas Anderson
2023-02-07 16:16 ` Guenter Roeck
2023-02-07 18:02 ` Jack Rosenthal [this message]
2023-02-08 20:39 ` Stephen Boyd
2023-03-06 2:43 ` patchwork-bot+chrome-platform
2023-03-06 2:53 ` patchwork-bot+chrome-platform
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y+KSTG92TtFK4PQm@chromium.org \
--to=jrosenth@chromium.org \
--cc=bleung@chromium.org \
--cc=chrome-platform@lists.linux.dev \
--cc=davidgow@google.com \
--cc=dianders@chromium.org \
--cc=gregkh@linuxfoundation.org \
--cc=groeck@chromium.org \
--cc=jwerner@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=swboyd@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox